Repository navigation
docs: hide contributors regenerate tip from the site - #1500
Merged
mrexox merged 3 commits intoAug 21, 2026
Merged
Conversation
docmd escapes HTML by default, so the old HTML comment leaked onto lefthook.dev/misc/contributors as visible text.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the regeneration command now emits raw Markdown bullets with GitHub profile URLs. Reviews (3): Last reviewed commit: "docs: fix contributors regenerate comman..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
docmd escapes HTML by default, so <!-- ... --> leaked onto the site. Use a markdown link-definition comment so the curl tip stays in the source but does not render.
MikevPeeren
changed the title
Include the markdown list marker and use html_url so regenerated entries match the existing contributor links.
Member
|
Oops, looks like docmd doesn't parse comments after the version update. Thank you for taking care! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl | jqregenerate tip in an HTML comment (<!--- ... -->).security.html: 'escape', so that comment is escaped and shown as visible text (also mangled by markdown-it’s typographer). Live example: https://lefthook.dev/misc/contributors/security.html: 'allow'would fix HTML comments but can also interpret placeholders like<shell>as tags, so instead use a markdown link-definition comment ([//]: # '...') that stays in the source and does not render.Test plan
docmd dev: https://lefthook.dev/misc/contributors/ equivalent page ends at “feel free to add yourself in a PR.” — no curl /<!—leakdocs/misc/contributors.mdstill contains the regenerate command