Repository navigation
Closed
Description
error-prone version: 2.21.0
BugPattern: NotJavadoc
Stack Trace:
java.lang.IllegalArgumentException: Overlapping ranges not permitted but found [89..95] overlapping [89..95]
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:445)
at com.google.common.collect.ImmutableRangeSet$Builder.build(ImmutableRangeSet.java:807)
at com.google.errorprone.bugpatterns.BugChecker.suppressedRegions(BugChecker.java:321)
at com.google.errorprone.bugpatterns.javadoc.NotJavadoc.matchCompilationUnit(NotJavadoc.java:62)
at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:449)
at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:555)
at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:150)
at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:591)
at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
at com.google.errorprone.scanner.Scanner.scan(Scanner.java:58)
at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:43)
at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:156)
at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1418)
at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1365)
at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:960)
at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104)
at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:147)
at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
at ...
The class that fails:
package name.remal.gradle_plugins.toolkit;
import lombok.Builder;
import lombok.Value;
@Value
@Builder
class CrossCompileServiceImpl {
String className;
CrossCompileServiceDependencyVersion dependencyVersion;
public boolean isFallback() {
return getDependencyVersion().getVersion() == null;
}
}lombok.config:
config.stopBubbling = true
lombok.addNullAnnotations = javax
lombok.fieldDefaults.defaultPrivate = true
lombok.toString.callSuper = call
lombok.equalsAndHashCode.callSuper = call
lombok.noArgsConstructor.extraPrivate = true
lombok.singular.auto = true
lombok.fieldNameConstants.uppercase = true
lombok.anyConstructor.addConstructorProperties = false
lombok.copyableAnnotations += com.fasterxml.jackson.annotation.JsonProperty
lombok.copyableAnnotations += org.springframework.beans.factory.annotation.Qualifier
lombok.copyableAnnotations += org.mockito.Mock
lombok.copyableAnnotations += org.mockito.Spy
lombok.copyableAnnotations += name.remal.gradle_plugins.toolkit.testkit.ChildProjectOf
lombok.copyableAnnotations += name.remal.gradle_plugins.toolkit.testkit.ApplyPlugin
lombok.accessors.flagUsage = warning
lombok.log.fieldname = logger
#lombok.log.custom.flagUsage = warning
lombok.log.custom.declaration = org.gradle.api.logging.Logger org.gradle.api.logging.Logging.getLogger(TYPE)
lombok.log.apacheCommons.flagUsage = warning
lombok.log.flogger.flagUsage = warning
lombok.log.javaUtilLogging.flagUsage = warning
lombok.log.jbosslog.flagUsage = warning
lombok.log.log4j.flagUsage = warning
lombok.log.log4j2.flagUsage = warning
lombok.log.slf4j.flagUsage = warning
lombok.log.xslf4j.flagUsage = warning
lombok.addLombokGeneratedAnnotation = true
lombok.addSuppressWarnings = true
lombok.extern.findbugs.addSuppressFBWarnings = true
lombok.utilityClass.flagUsage = error
Metadata
Metadata
Assignees
Labels
No labels
Activity
cushon commentedon Aug 3, 2023
This looks like the same crash as #4034
Do you know what code lombok is generating, e.g. what the output of https://projectlombok.org/features/delombok is?
remal commentedon Aug 4, 2023
@cushon,
Delombok output.
Β
I also set a breakpoint to BugChecker:321.
What ErrorProne sees.
msridhar commentedon Aug 4, 2023
We are seeing this same new crash in the NullAway repo when updating to EP 2.21.0. To repro, check out this branch:
https://github.com/msridhar/NullAway/tree/not-javadoc-lombok-crash-repro
And then run
./gradlew :test-java-lib-lombok:compileJava. When building on either JDK 11 or JDK 17 I get this crash:I see the same crash when updating our Lombok dependence to the latest version, 1.18.28.
cushon commentedon Aug 4, 2023
Some printf debugging with the NullAway repro shows the usual issue with Lombok generating AST nodes with synthetic nodes with bogus positions that overlap, e.g.
msridhar commentedon Aug 4, 2023
Also reported at projectlombok/lombok#3476 in case it can be fixed on the Lombok side
cushon commentedon Aug 4, 2023
I have a pending fix to handle the overlapping ranges, I think it's harmless to ignore the overlaps and that will result in
NotJavadocsuccessfully handling those@SuppressWarnings annotationsHandle overlapping ranges in suppressedRegions
Handle overlapping ranges in suppressedRegions
msridhar commentedon Aug 4, 2023
Confirmed that Error Prone 2.21.1 works without crashing for NullAway's Lombok test. Thanks @cushon!
Stephan202 commentedon Aug 7, 2023
I referenced this issue in google/guava#3033; that feature could prevent issues such as this one in the future.