Skip to content

Thread bindnode options through convenience calls - #572

Merged
hannahhoward merged 1 commit into
masterfrom
feat/pass-options
Sep 14, 2024
Merged

hannahhoward merged 1 commit into
masterfrom
feat/pass-options

Conversation

@hannahhoward

Copy link
Copy Markdown
Collaborator

Goals

a user of the codec helpers might want to be able to use custom bindnode options to assist in Mashalling/Unmarshalling their types

Implemention

Add opts ...bindnode.Options as parameter to various helpers and pass it through to the underlying bindnode functions.

For discussion

Pretty sure it's fine but passing bindnode options to both prototype call and wrap call in UnmarshalStreaming could have unintended effects? Not sure which is should properly go to though.

a user of the codec helpers might want to be able to use custom bindnode options to assist in
Mashalling/Unmarshalling their tyoes
@hannahhoward
hannahhoward requested a review from rvagg September 14, 2024 14:40
@hannahhoward
hannahhoward merged commit f75d95e into master Sep 14, 2024
@hannahhoward
hannahhoward deleted the feat/pass-options branch September 14, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants