[jdx]

Summary

• stage go.mod and go.sum updates produced by gomod_tidy when Go source changes
• cover nested-module manifest staging with both Git backends
• leave ShellCheck autofixing to feat(builtins): add shellcheck fix via check_diff #1237 and the ls_lint builtin to feat(builtins): add ls_lint linter #1238

Related to #1234.

Test evidence

• mise run pkl:gen
• mise run build
• mise run test:bats test/gomod_tidy_nested_module.bats
• git diff --check

AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.

---

Note

Low Risk
Builtin staging behavior only; no auth, runtime, or broad execution changes beyond ensuring Go module manifests are indexed after tidy.

Overview
gomod_tidy now declares stage = List("go.mod", "go.sum") so manifest updates from go mod tidy are added to the index when the step was triggered by a .go change (default staging only followed the step globs and could leave tidied go.mod/go.sum unstaged).

A new bats case in gomod_tidy_nested_module.bats covers a nested module: after staging only svc/main.go, hk fix --step gomod_tidy must leave both the Go file and svc/go.mod in the cached diff with no leftover unstaged manifest changes.

^{Reviewed by Cursor Bugbot for commit 0dc0d59. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: bb864186-5f89-4733-9a69-7e9d318e26e9

📥 Commits

Reviewing files that changed from the base of the PR and between 5d5a94d and 1428b37.

⛔ Files ignored due to path filters (3)

• pkl/builtins/gomod_tidy.pkl is excluded by !**/*.pkl
• pkl/builtins/ls_lint.pkl is excluded by !**/*.pkl
• pkl/builtins/shellcheck.pkl is excluded by !**/*.pkl

📒 Files selected for processing (3)

• test/builtin_tool_stubs/ls-lint
• test/gomod_tidy_nested_module.bats
• test/shellcheck_fix.bats

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The changes add an ls-lint tool stub and integration tests for ShellCheck fixes and gomod_tidy behavior in nested Go modules.

Changes

Integration test coverage

Layer / File(s)	Summary
ShellCheck fix validation test/shellcheck_fix.bats, test/builtin_tool_stubs/ls-lint	The new Bats test configures Builtins.shellcheck, validates automatic backtick conversion, and checks failure handling for SC2034. The test environment includes the builtin tool stub path and an ls-lint Mise stub.
Nested gomod_tidy validation test/gomod_tidy_nested_module.bats	The integration test verifies that gomod_tidy stages both nested module source changes and the updated go.mod file without an unstaged manifest diff.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 1428b

This PR adds localized Go and shell linting behavior plus an ls-lint builtin; no actionable merge-blocking risk remains after normal checks and review.

Poem

A rabbit checks the staged rows,
ShellCheck trims the tangled toes.
Go modules tidy in their burrow,
Tool stubs guide each careful sparrow.
Clean diffs rest beneath the moon.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the gomod_tidy manifest-staging change covered by the pull request. It does not mention the ShellCheck and ls_lint changes, but the title may focus on one significant p…

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

Full details: Title check

Explanation

The title clearly describes the gomod_tidy manifest-staging change covered by the pull request. It does not mention the ShellCheck and ls_lint changes, but the title may focus on one significant part of the changeset.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 1428b37. Configure here.}

[greptile-apps]

Greptile Summary

The PR updates gomod_tidy so manifest changes produced while fixing Go source are staged alongside the triggering files.

• Adds workspace-relative staging patterns for go.mod and go.sum.
• Adds a nested-module integration test verifying that the changed Go file and tidied manifest are staged.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
pkl/builtins/gomod_tidy.pkl	Adds workspace-aware staging of Go module manifests after go mod tidy fixes.
test/gomod_tidy_nested_module.bats	Verifies that a Go-source-triggered tidy in a nested module stages both the source file and updated manifest.

_{Reviews (4): Last reviewed commit: "fix(builtins): stage gomod_tidy manifest..." | Re-trigger Greptile}

[github-actions]

Instruction counts

Nothing was compared, and so nothing was gated. No series appears on both sides: either the base has no measurements recorded, or the two were measured on different runner classes, which are deliberately not comparable — counts shift between machine types by more than a real regression does.

New, nothing to compare against: builtins on bamboo-v2-ubuntu24.04-x64-30vcpu-24gb-rust1.97.1, check on bamboo-v2-ubuntu24.04-x64-30vcpu-24gb-rust1.97.1, usage on bamboo-v2-ubuntu24.04-x64-30vcpu-24gb-rust1.97.1, validate on bamboo-v2-ubuntu24.04-x64-30vcpu-24gb-rust1.97.1

_{Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.}

_{Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.}

_{0dc0d59c746e vs 7d50fee00327 · measured on the runner, not pushed to the history.}