[zeitlinger]

The typos builtin captures its diagnostic output in a shell variable before returning it. With a custom shell that does not enable errexit (for example, shell = "sh -c"), a failing typos invocation can otherwise be followed by the empty-output success path and incorrectly report success.

Preserve the command's status explicitly before the empty-output check. The default hk shell already enables errexit; this fix specifically protects custom shells that opt out of it.

Tests cover invalid native configuration, the builtin check/fix cases, and both default-errexit and custom sh -c shells.

AI-assisted — Tool: Codex; model: OpenAI/unavailable; version: unavailable.

Summary by CodeRabbit

• Tests
  • Added coverage for the typos check and fix workflows.
  • Verified configuration exclusions and automatic correction of invalid files.
  • Confirmed error statuses and messages are preserved when configuration cannot be read or contains invalid TOML.
  • Tested behavior across supported shell execution modes, including diff output and prevention of unintended fallback actions.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 8c590fd4-c0b4-42c4-a6f2-7735e54e3b83

📥 Commits

Reviewing files that changed from the base of the PR and between 894f0e2 and 6a513bd.

⛔ Files ignored due to path filters (1)

• pkl/builtins/typos.pkl is excluded by !**/*.pkl

📒 Files selected for processing (1)

• test/typos.bats

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The PR adds BATS coverage for the typos builtin. The tests cover successful checks and fixes, tool exit-code and stderr propagation, diff-based fixes, and invalid TOML configuration.

Changes

Typos builtin test coverage

Layer / File(s)	Summary
Test harness and successful typos runs test/typos.bats	Adds setup for the typos builtin and verifies successful check and fix scenarios.
Failure propagation and diff-based fixes test/typos.bats	Verifies exit code 78 and stderr propagation. It also verifies that hk fix applies the diff output and does not use the --write-changes fallback.
Invalid native configuration test/typos.bats	Verifies that check and fix fail when typos.toml contains invalid TOML.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 6a513

The custom-shell regression cases are covered; no actionable merge risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: preserving errors from the typos builtin when custom shells are used.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; the previously reported loss of captured diffs is resolved and no new actionable issue remains.

Summary

This PR fixes the typos builtin’s behavior under custom shells that do not enable errexit.

• Captures the typos --diff exit status without discarding stdout.
• Preserves silent operational failure statuses while forwarding captured typo diffs.
• Adds builtin and Bats coverage for invalid configuration, check/fix behavior, default shells, and custom sh -c shells.

_{Reviews (2) · Last reviewed commit: "fix(builtins): preserve typos diffs with..."}