[jdx]

https://entire.com/gh/jdx/-/trails/2898/changes/hk/307

Every open PR is failing in mise lock / mise install with failed to resolve java for windows-arm64: no metadata found for version 21.0.13+9.0.LTS, because Temurin 21.0.13 has no Windows metadata yet. This pins the java that the bats setup installs, so mise stops resolving 21.0.13.

• mise-tasks/test/bats/setup: java = "21" becomes java = "21.0.12".
• mise.lock: the java entry's specifier becomes 21.0.12 to match; the locked version (21.0.12+101.0.LTS) and checksums are unchanged.
• Java is only needed for the google-java-format and ktlint builtin tests. Dropping it was tried first and does not work: ktlint's mise tool depends on mise-managed java, so the macOS ktlint tests failed with java@21.0.13+9.0.LTS not installed instead of using the runner's JDK.

Revert this pin (back to java = "21") once Temurin 21.0.13 ships Windows metadata. Existing Renovate PRs need a rebase onto main after this lands.

🤖 Generated with Claude Code

AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: unavailable.

Summary by CodeRabbit

• Chores
  • The test setup now specifies Java 21.0.12 instead of Java 21. This makes the Java version used by the setup more precise; no application feature changes are included.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: jdx/hk
• Branch: chore/drop-java-from-bats-setup
• File: .coderabbit.yaml
• Commit: f90865c
• Layers: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4fd7714f-4007-4bcf-8f39-d1c65773e58f

Commits

Reviewing files that changed from the base of the PR and between d8ede03 and f90865c.

Files ignored due to path filters: 1

• mise.lock is excluded by !**/*.lock

Files selected for processing: 1

• mise-tasks/test/bats/setup

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The Bats test setup script changes its mise Java version from 21 to 21.0.12.

Changes: Bats test setup

Layer / File(s)	Summary
Pin Java version mise-tasks/test/bats/setup	The mise Java version changes from 21 to 21.0.12.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: Minimal · up to f9086

The change pins the Java version used by the builtin Bats tests, which keeps mise installs working until Windows builds exist for Temurin 21.0.13. No actionable merge-blocking risk remains.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: pinning Bats CI Java to 21.0.12 because Temurin 21.0.13 lacks Windows builds.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

[greptile-apps]

Confidence Score: 5/5

[Low impact] The final change appears safe to merge; no actionable defects were found.

Summary

The final change pins the Bats JDK instead of using the runner’s JDK, despite the earlier PR description.

• Bats setup now pins Java 21.0.12 for its builtin tests.

_{Reviews (2) · Last reviewed commit: "chore(test): pin bats java to 21.0.12 un..." · Reviewed by Greptile}

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

[github-actions]

Instruction counts

benchmark	trend	instructions	Δ	wall (min)	Δ
builtins	▁▁▁▂▄▄▄▄▄▅▅▅▅▄▅█	1,972,221 → 1,979,605	+0.37%	2.95 → 3.05ms	+3.18%
check	—	—	—	18.83 → 19.23ms	+2.11%
config-cold	▂▁▁▁▁▁▁▂▂██████▇	78,272,584 → 78,174,828	-0.12%	22.92 → 23.18ms	+1.13%
stash	▁▁▂▁▄▃▄▃▄▄▃▃▃▄▃█	54,149,311 → 54,754,672	+1.12% ⚠️	287.55 → 292.69ms	+1.79%
usage	▇▇▇▇██████████▅▁	4,372,372 → 4,344,658	-0.63%	5.16 → 5.06ms	-2.00%
validate	—	—	—	15.11 → 15.20ms	+0.59%

1 benchmark(s) above the 1% gate: stash +1.12%

_{Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.}

_{Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.}

_{f90865cd9e94 vs 1c067c5b0132 · measured on the runner, not pushed to the history.}