Repository navigation
fix(bootstrap): pin relative config dir during reexec - #12721
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe Git bootstrap re-execution now converts a relative ChangesGit bootstrap configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change keeps relative configuration directories stable when bootstrap re-executes from a cloned repository and adds coverage for the behavior. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR preserves a relative
Confidence Score: 5/5The PR appears safe to merge, with the relative configuration directory preserved consistently across the checkout re-exec. Startup applies directory selection before bootstrap dispatch, so the new absolute path uses the same base as parent configuration discovery, while default and already-absolute paths retain their existing effective values. Important Files Changed
Reviews (1): Last reviewed commit: "fix(bootstrap): pin relative config dir ..." | Re-trigger Greptile |
Summary
MISE_CONFIG_DIRacross thebootstrap --from-gitchild re-execTesting
mise run test:e2e e2e/cli/test_bootstrap_frommise run lint-fixAI-assisted — Tool: Codex; model: OpenAI/GPT-5; version: unavailable.
Note
Low Risk
Narrow bootstrap
--from-gitre-exec env forwarding fix with E2E coverage; no auth or data-path changes beyond config directory resolution.Overview
bootstrap --from-gitclones into the config directory and re-runs mise from that checkout. Without pinning, a relativeMISE_CONFIG_DIRwould be reinterpreted after the child changes working directory, so the clone location and config discovery could diverge from what the parent intended.This change resolves relative
MISE_CONFIG_DIRagainst the parent’s current directory and passes the absolute path into the child viaMISE_CONFIG_DIR, mirroring the existing behavior for relativeMISE_GLOBAL_CONFIG_FILE. Optional global config file forwarding stays under the samefrom_gitblock.E2E coverage asserts that with a relative config dir, the repo is cloned there,
originmatches, and the bootstrap task still runs.Reviewed by Cursor Bugbot for commit 62e062b. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
--from-gitbootstrapping whenMISE_CONFIG_DIRis set to a relative path.