Skip to content

fix(schema): add missing built-in deps providers - #12739

Merged
jdx merged 2 commits into
jdx:mainfrom
risu729:fix/schema-deps-providers
Sep 4, 2026
Merged

jdx merged 2 commits into
jdx:mainfrom
risu729:fix/schema-deps-providers

Conversation

@risu729

@risu729 risu729 commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add named schema entries for the built-in aube, deno, and git-submodule dependency providers
  • keep each entry aligned with the shared deps_provider definition

This is split out of #12528 so the dependency-provider schema gap can be reviewed independently. Custom dependency providers remain supported through additionalProperties; these named entries restore editor discovery and completion for built-in providers.

Gap provenance

Validation

  • mise run render:schema
  • mise run test:e2e e2e/config/test_schema_tombi e2e/config/test_schema_deps_provider_arrays
  • mise run lint-fix

AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.

Summary by CodeRabbit

  • New Features
    • Added schema support for the aube, deno, and git-submodule dependency providers.
    • Added a state option for bootstrap packages, supporting present or absent values with present as the default.

AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Team

Run ID: cda8de75-adcc-4c3d-90b4-50088c7e7a68

📥 Commits

Reviewing files that changed from the base of the PR and between b4be3b6 and 1de5d25.

📒 Files selected for processing (1)
  • schema/mise.json

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The mise JSON schema adds aube, deno, and git-submodule dependency providers. Bootstrap package entries now support a state value of present or absent, with present as the default.

Changes

Schema updates

Layer / File(s) Summary
Dependency provider entries
schema/mise.json
The deps provider object adds aube, deno, and git-submodule entries that reference deps_provider.
Bootstrap package state
schema/mise.json
Bootstrap package entries add a state field with present and absent values. The default is present.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 1de5d

This expands configuration editor support for built-in dependency providers and package presence state without identified current-head correctness or compatibility risk.

Suggested reviewers: jdx, jambalaya56562, marukome0743

Poem

A rabbit checks the schema bright
Three new providers hop in sight
Packages choose their state with care
Present or absent, neatly there
The default waits at present fair

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding missing built-in dependency providers to the schema. It is concise and specific.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds named schema entries for the built-in aube, deno, and git-submodule dependency providers.

  • Reuses the shared deps_provider definition for all three entries.
  • Preserves support for custom providers through additionalProperties.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
schema/mise.json Adds three built-in dependency-provider properties using the same schema reference as existing providers.

Reviews (3): Last reviewed commit: "test(schema): remove redundant deps prov..." | Re-trigger Greptile

@risu729
risu729 force-pushed the fix/schema-deps-providers branch from b4be3b6 to 59bfd2d Compare September 4, 2026 18:50
@risu729
risu729 force-pushed the fix/schema-deps-providers branch from 59bfd2d to 1de5d25 Compare September 4, 2026 19:53
@risu729
risu729 marked this pull request as ready for review September 4, 2026 21:19
@jdx
jdx merged commit e2925ed into jdx:main Sep 4, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants