[jdx]

macOS defaults status can display identical desired and current values while reporting differs, because comparison includes the property-list type. Show the actual and expected types when they differ: an integer KeyRepeat = 2 against a stored real now reports 2 (real; expected integer) in Current. Strict comparison and apply behavior remain unchanged; same-type value differences keep their existing display.

Validation: focused defaults unit tests, a macOS E2E test using an isolated preference domain, scoped hk checks, and Rust formatting. The E2E test verifies text and JSON output, read-only status, and string-to-integer correction through apply.

Native testing also exposed an existing write limitation: CFPreferences can retain a real 2.0 when applying integer 2. This PR explains the resulting status mismatch; it does not change that write behavior.

AI-assisted — Tool: Codex; model: openai/unavailable; version: unavailable.

---

Note

Low Risk
Read-only change to status messaging and tests; macOS defaults matching and write paths are untouched.

Overview
macOS defaults status now explains why a preference shows as differs when the printed value looks the same as config: strict matching already required matching property-list types, but Current only showed the raw value.

When the stored type does not match the expected type, Current is now annotated like 2 (real; expected integer) or 15 (string; expected integer). Same-type value mismatches keep the plain value display. Compare/apply behavior is unchanged—this is status output only.

Coverage adds unit tests for display_difference and a Darwin-only E2E that seeds mismatched types in an isolated preference domain, checks text/JSON status, read-only --missing, and that apply still corrects a string stored as an integer.

^{Reviewed by Cursor Bugbot for commit 315f291. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• Bug Fixes
  • Preference status output now identifies both current and expected property-list types when a value has the wrong type.
  • Applying system defaults corrects compatible type mismatches while preserving values that should not be changed.
  • Read-only status checks preserve existing preference values and types without modifying them.
• Tests
  • Added macOS coverage for detecting, displaying, and applying preference type mismatches, including numeric and string values.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: e1888c13-d716-4725-ae92-4ece752c012f

📥 Commits

Reviewing files that changed from the base of the PR and between 24d458d and 315f291.

📒 Files selected for processing (1)

• src/system/defaults.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.

---

📝 Walkthrough

Walkthrough

The defaults status flow derives expected type names from DefaultsValue variants. A macOS end-to-end test validates mismatch reporting, JSON output, read-only behavior, and apply behavior.

Changes

Defaults type reporting

Layer / File(s)	Summary
Type-aware difference display src/system/defaults.rs	display_difference maps each DefaultsValue variant to its expected type name without creating a temporary plist value.
Status integration and macOS validation e2e/cli/test_system_defaults_types	The macOS end-to-end test checks mismatched type output, JSON status, read-only preservation, and correction of the string value during apply. The float value remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: azohra

Merge Risk: ⚪ Minimal · up to 315f2

The PR improves macOS defaults mismatch reporting without changing apply behavior, and the relevant output and apply paths are covered by tests.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: improving macOS defaults output to explain type differences.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge with no outstanding correctness, security, or repository-rule issues identified.

Summary

• Preserves existing comparison and apply behavior.
• Keeps same-type value differences unchanged.
• Adds focused unit coverage and a Darwin-only end-to-end workflow covering text output, JSON output, read-only status, and apply behavior.

_{Reviews (2) · Last reviewed commit: "fix(bootstrap): format defaults types on..."}

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

[github-actions]

Instruction counts

The comparison never ran — an earlier step failed.

_{315f2910ecec vs `` · measured on the runner, not pushed to the history.}