[JamBalaya56562]

mise runs a daemon's ready_cmd and health_cmd through mise x, so the probe sees the project's tools and [env], not whatever environment the shared pitchfork supervisor happened to start with. Two kinds of probe skipped that:

• An argument array. pitchfork 2.30.0 accepts ready_cmd and health_cmd as an argument array, which it runs without a shell (feat(config): accept an argv array for ready_cmd to probe without a shell pitchfork#1012, rtx manipulate path even when using shims #1015). mise wrapped only a string, so an array ran outside mise x.
• Any custom probe on Windows. For a run or task daemon, mise wrapped probes on Unix only. Preset probes were already wrapped on Windows too (feat(daemons): support daemon presets on Windows #13929).

[env]
DATABASE_URL = "postgres://127.0.0.1:5432/app"

[daemons.api]
run = "node server.js"
ready_cmd = ["node", "scripts/ready.js"]

Here the probe found neither the project's node nor DATABASE_URL when the supervisor had been started from another project. It failed until pitchfork's timeout, and mise daemons start reported the daemon as failed.

mise now wraps both kinds:

• An array stays an array: ["<mise>", "x", "--", "node", "scripts/ready.js"], still run without a shell.
• A string on Windows becomes "<mise>" x -- cmd /c <command>, the form presets use, with the command escaped for cmd.

mise = false still leaves probes unwrapped. The docs now describe this and the array form.

Validation

• New unit test argv_probes_stay_argv_inside_the_tool_environment checks both ready_cmd and a structured health_cmd. The existing task_probe_environment_respects_explicit_opt_out now runs on Windows too.
• New e2e-win/daemons_probe_env.Tests.ps1 starts the pitchfork 2.30.0 supervisor from a directory without the project's [env], then starts a daemon whose readiness probe passes only when it sees a value from [env]. It covers an array probe and a string probe. With mise 2026.10.2 on Windows 11, both daemons failed when the 30-second ready timeout ran out (exit code 124), and the probe ran unwrapped. With this change, built by CI, both pass, and so do the existing daemons_task and daemons_task_init e2e tests.

AI-assisted — Tool: Claude Code; model: anthropic/claude-opus-5-5; version: unavailable.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Readiness and health checks now use the project’s tools and environment settings across platforms, unless a daemon opts out with mise = false.
  • Probe commands can be configured as argument arrays. Pitchfork 2.30.0 and later runs these without a shell.
• Documentation
  • Updated daemon guidance to explain probe environment behavior and argument-array command support.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: f7946949-a8b0-40d5-a5fb-c7714a02dba3

📥 Commits

Reviewing files that changed from the base of the PR and between ee94b79 and 7ee3390.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: fe052991-6d4b-495d-909c-e432f34c9aaa

📥 Commits

Reviewing files that changed from the base of the PR and between e343483 and ee94b79.

📒 Files selected for processing (1)

• e2e-win/daemons_probe_env.Tests.ps1

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

Daemon readiness and health probes now support string and argv commands through mise x across platforms, unless mise = false. Windows end-to-end tests cover project environment values for both ready_cmd forms. Documentation describes the behavior and Pitchfork’s argv-command support.

Changes

Daemon probe execution

Layer / File(s)	Summary
Wrap probe commands across platforms src/daemons/presets.rs, src/daemons/mod.rs, src/daemons/runtime.rs	Probe wrapping handles string commands and argv commands, including structured probe tables. Task-daemon and custom-probe wrapping no longer depends on the platform being Unix. The argv-probe test checks ready_cmd and health_cmd.run.
Test and document probe environments e2e-win/daemons_probe_env.Tests.ps1, docs/daemons.md	Windows end-to-end tests verify that string and argv ready_cmd forms receive the project’s [env] value. Documentation describes tool and environment use, the mise = false exception, and argv command support in Pitchfork 2.30.0 and later.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to ee94b

The Windows probe tests cover both argv and string readiness commands; no merge-blocking concern was identified in the supplied evidence.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main changes: running argv readiness probes and Windows readiness probes in the tool environment.
Docstring Coverage	✅ Passed	Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. (1 skipped: 1 u…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[High risk] Daemon readiness probes now run on Windows with tool environment.

The PR appears safe to merge; no actionable new issue was found.

What we checked:

• Explicit opt-outs still work: Each wrapper caller checks the explicit opt-out before changing the probe.

Summary

Readiness and health probes now use the project's tools and environment for argument arrays and custom Windows commands.

• Argument arrays stay arrays when wrapped in mise x.
• mise = false still leaves probes unchanged.
• Adds Windows readiness tests and updates the daemon guide.
• The earlier supervisor-startup concern is fixed: the test saves its output and checks its exit code.

_{Reviews (3) · Last reviewed commit: "fix(daemons): run argv and Windows readi..." · Reviewed by Greptile}