[thespags]

TL:DR Simple fix to encode nested / for gitlab

Installing a GitLab release whose tag contains a slash, such as the admin-cli/v0.34.783 tags that monorepo-style projects use, failed with a 404:

mise install gitlab:group/project@admin-cli/v0.34.783

mise percent-encoded the project path when it looked up the release but put the tag into the URL as-is, so it requested .../releases/admin-cli/v0.34.783. GitLab only resolves such tags when they are encoded in the path, as admin-cli%2Fv0.34.783. The tag is now encoded the same way as the project.

Before / after, against a real private GitLab project with slash tags:

GET .../projects/<group>%2F<project>/releases/admin-cli/v0.34.783    -> 404 (before)
GET .../projects/<group>%2F<project>/releases/admin-cli%2Fv0.34.783  -> 200 (after)

With the fix, mise install gitlab:<group>/<project>@admin-cli/v0.34.783 downloads and extracts the matching OS/arch asset. Tags without a slash are unaffected.

Validation: added test_get_release_encodes_slash_in_tag, which fails without the change and passes with it. The existing gitlab tests pass, and cargo clippy -p mise-util --all-targets -- -D warnings is clean. I also confirmed the install end to end against the project above. I did not run the e2e suite.

AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: unavailable.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Fixed release lookups for tags containing slashes, so they can be retrieved correctly from GitLab.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 564b0a30-1c8c-4431-a267-e17d5ddb0817

📥 Commits

Reviewing files that changed from the base of the PR and between 4a92154 and edf9838.

📒 Files selected for processing (1)

• crates/mise-util/src/gitlab.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

get_release_ percent-encodes release tags when building GitLab release URLs. A regression test checks the request path and returned tag for a slash-containing tag.

Changes

GitLab release lookup

Layer / File(s)	Summary
Encode release tags in URL crates/mise-util/src/gitlab.rs	get_release_ percent-encodes the tag in the release URL. A regression test checks the encoded request path and confirms the returned tag is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: jdx

Merge Risk: ⚪ Minimal · up to edf98

Slash-containing release tags are now addressed as a single encoded URL path segment. No actionable merge-blocking risk remains in the reviewed change; it is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	⚠️ Warning	The title accurately describes percent-encoding the tag for GitLab release lookups, but the fix(github) scope is incorrect. The change targets GitLab, not GitHub.	Change fix(github) to fix(gitlab), for example: fix(gitlab): percent-encode the tag in release lookups.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

• Fix all pre-merge checks with AI

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Fixes URL encoding in GitLab release API calls.

The PR appears safe to merge; no actionable issues were found.

What we checked:

• Slash tags use one path segment: get_release_ encodes the tag before building the request. The new test requires %2F in the request path.

Summary

Percent-encodes the tag in GitLab release requests so tags containing / stay within one URL path segment.

• Adds a regression test for admin-cli/v1.2.3.
• Checks the encoded request path and preserves the returned tag name.
• No actionable issues found. Tests were not run during this review.

_{Reviews (1) · Last reviewed commit: "Merge branch 'main' into fix/gitlab-enco..." · Reviewed by Greptile}