[onokonem]

Fixes the first two points of #14149.

A [plugins] entry in the git::<url>//<subdir>?ref=<ref> form installs, but:

• On a data dir that never held a plugin, the install clones into plugin-repos/ and fails linking plugins/<name> because nothing created plugins/ (failed to ln -sf … No such file or directory). install_git_plugin_source now creates the parent before make_symlink.
• configured_plugin_url expanded the entry as a registry shorthand (https://github.com/:ssh://….git). The drift check then warned on every mise install, and mise plugins install --force <name> reinstalled from the mangled URL, failed and left no plugin. plugin_entry_to_url now keeps a source that RemoteSource::parse_git recognises as is.

Tests:

• test_plugin_entry_to_url_keeps_ref_outside_shorthand_expansion gets git:: ssh/https cases (with and without ?ref=).
• test_install_git_plugin_source_subdir_creates_the_plugins_dir installs a local subdirectory plugin into a plugins/ that does not exist yet.

Both fail on main without the change (left: "https://github.com/:ssh://…"; failed to ln -sf … No such file or directory) and pass with it. cargo fmt --check and cargo clippy --lib --tests -- -D warnings are clean.

The third point of the issue (auto-install of mise run / mise exec resolving tools before [plugins] is installed) is not addressed here.

---

Drafted with AI assistance (Claude Code); I reviewed the change and the tests before opening it.

Summary by CodeRabbit

• Bug Fixes
  • Git plugin sources using SSH or HTTPS URLs are now preserved, including sources that specify a subdirectory.
  • Installing a plugin from a checked-out subdirectory now works when the plugins directory does not yet exist.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 56c375c0-1d89-4a2b-93a7-5b49d1383f5a

📥 Commits

Reviewing files that changed from the base of the PR and between e57c274 and bc9b666.

📒 Files selected for processing (2)

• src/config/mod.rs
• src/plugins/mod.rs

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1c5227cf-bfcf-4dba-b19a-6700538f48b6

📥 Commits

Reviewing files that changed from the base of the PR and between 4a98b02 and e57c274.

📒 Files selected for processing (2)

• src/config/mod.rs
• src/plugins/mod.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The change preserves recognized git:: plugin sources during URL expansion and creates a missing parent directory before installing a checked-out Git subdirectory.

Changes

Git Plugin Sources

Layer / File(s)	Summary
Preserve Git source URLs src/config/mod.rs	Recognized git:: sources are returned unchanged before shorthand URL expansion. Tests cover SSH and HTTPS sources, with and without a subdirectory ref.
Create parent directory for subdirectory installs src/plugins/mod.rs	The installer creates the plugin path’s parent directory before symlinking a checked-out subdirectory. A test covers installation when the target plugins/ directory does not exist.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: jdx

Merge Risk: ⚪ Minimal · up to e57c2

Git subdirectory sources now reach the existing drift and install paths, and installs can create a missing plugins directory. No material merge risk is established.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the plugin fixes for installing and comparing git:: subdirectory sources from the [plugins] configuration.
Docstring Coverage	✅ Passed	Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Adds subdirectory support to plugin installation from git sources.

The PR appears safe to merge; no actionable issues were found.

What we checked:

• Git sources reach the right repository: Both paths parse the preserved entry before using it. The drift check compares the extracted URL, and installation clones that URL with the extracted ref and subdirectory.

Summary

Keeps recognized git:: plugin entries unchanged instead of expanding them as registry shorthand.

• Adds SSH and HTTPS cases to the URL conversion test.
• Adds a local repository test for installing a subdirectory plugin when plugins/ does not exist.
• The directory-creation fix described in the PR is already present in the target commit; this diff adds its regression test.

_{Reviews (2) · Last reviewed commit: "fix(plugins): drop the plugins dir creat..." · Reviewed by Greptile}