Repository navigation
Java 11 HTTP client reuse covers ordinary connections - #2584
Merged
Merged
Conversation
Requests from Jsoup.newSession() already reused their HttpClient. This extends that reuse to independent Jsoup.connect(...) calls, so repeated requests do not create a new transport client and its threads each time. Custom authentication and SSL contexts remain isolated, and proxy selection remains per request. Fixes: #2516
Owner
Author
|
Both runs used JDK 21.0.12, 200 requests, and concurrency 32 where applicable.
So this really improves both thread / GC, and ability for connection keep-alive, when using independent requests vs session requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests via
Jsoup.newSession()already reused their HttpClient. This extends that reuse to independentJsoup.connect(...)calls, so repeated requests do not create a new transport client and its threads each time.Custom authentication and SSL contexts remain isolated, and proxy selection remains per request.
Fixes: #2516