Skip to content

Don't change keybindings to emacs for dumb terminals - #953

Merged
gnodet merged 1 commit into
jline:masterfrom
hvesalai:master
Apr 17, 2024
Merged

gnodet merged 1 commit into
jline:masterfrom
hvesalai:master

Conversation

@hvesalai

Copy link
Copy Markdown
Contributor

Fix for #864

@hvesalai

hvesalai commented Mar 15, 2024 •

Copy link
Copy Markdown
Contributor Author

Could we have yet an other 3.24. branch release for this? (and naturally also 3.25)

@hvesalai

Copy link
Copy Markdown
Contributor Author

@gnodet apparently scala and sbt are moving to 3.25 "soon", so I'm also happy if you justs make a new 3.25.2 release with this so it will get included.

@gnodet
gnodet self-requested a review March 20, 2024 07:28
@hvesalai

Copy link
Copy Markdown
Contributor Author

@gnodet any feedback?

@hvesalai

hvesalai commented Apr 6, 2024

Copy link
Copy Markdown
Contributor Author

@gnodet I'm still pushing this. The problem here is that it forces dumb terminals to have the emacs bindings, including the parenthesis matching that breaks echo.

@hvesalai

Copy link
Copy Markdown
Contributor Author

@gnodet upping this again. It's a clear bug fix and shouldn't need hesitation to be merged.

@gnodet gnodet added this to the 3.26.0 milestone Apr 17, 2024
@gnodet
gnodet merged commit f086431 into jline:master Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants