Skip to content

log on error when handling rpc in extensions - #668

Merged
MarcoPolo merged 1 commit into
masterfrom
push-trzlxpssuoly
Mar 18, 2026
Merged

MarcoPolo merged 1 commit into
masterfrom
push-trzlxpssuoly

Conversation

@MarcoPolo

Copy link
Copy Markdown
Contributor

No description provided.

@MarcoPolo
MarcoPolo requested a review from sukunrt January 31, 2026 02:01
Comment thread gossipsub.go Outdated
gs.extensions.HandleRPC(rpc)
err := gs.extensions.HandleRPC(rpc)
if err != nil {
gs.logger.Warn("error in handling RPC", "err", err)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the rpc has from we can log more details.

@MarcoPolo
MarcoPolo merged commit 12372d9 into master Mar 18, 2026
9 checks passed
@MarcoPolo
MarcoPolo deleted the push-trzlxpssuoly branch March 18, 2026 18:46
MarcoPolo added a commit that referenced this pull request Apr 17, 2026
This release introduces support for the partial messages extension. The
partial messages extension gives the application precise control on
exchanging message metadata and exchanging parts of messages. Unlike
normal Gossipsub messages, Partial Messages are not opaque and peers can
exchange message metadata separately from message data. An example use
case is reconcilling when peers have some or all of a message. This
works in a backwards compatible way.

Notable changes:

- Message filter option β€” WithMessageFilter to filter messages early in the notification pipeline (#678).
- Fanout-only topics β€” New FanoutOnly topic option (#676).
- Dynamic direct peer handling β€” Threadsafe dynamic direct peer management for GossipSub (#673).

Fixes & improvements:

- Structured RPC logging
- Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first)
- Renamed {Add/Remove}Peer β†’ On{New/Closed}OutboundStream
- partialmessages: init fanout if empty (#690)
- Log errors when handling RPC in extensions (#668)
- Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages
- Added Rpc.From()
MarcoPolo added a commit that referenced this pull request Apr 17, 2026
This release introduces support for the partial messages extension. The
partial messages extension gives the application precise control on
exchanging message metadata and exchanging parts of messages. Unlike
normal Gossipsub messages, Partial Messages are not opaque and peers can
exchange message metadata separately from message data. An example use
case is reconcilling when peers have some or all of a message. This
works in a backwards compatible way.

Notable changes:

- New FanoutOnly topic option (#676).
- WithMessageFilter to filter messages early in the notification pipeline (#678).

Fixes & improvements:

- Structured RPC logging
- Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first)
- Renamed {Add/Remove}Peer β†’ On{New/Closed}OutboundStream
- partialmessages: init fanout if empty (#690)
- Log errors when handling RPC in extensions (#668)
- Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages
- Added Rpc.From()
- Threadsafe dynamic direct peer management for GossipSub (#673).
@MarcoPolo MarcoPolo mentioned this pull request Apr 17, 2026
MarcoPolo added a commit that referenced this pull request Apr 18, 2026
This release introduces support for the partial messages extension. The
partial messages extension gives the application precise control on
exchanging message metadata and exchanging parts of messages. Unlike
normal Gossipsub messages, Partial Messages are not opaque and peers can
exchange message metadata separately from message data. An example use
case is reconcilling when peers have some or all of a message. This
works in a backwards compatible way.

Notable changes:

- New FanoutOnly topic option (#676).
- WithMessageFilter to filter messages early in the notification pipeline (#678).

Fixes & improvements:

- Structured RPC logging
- Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first)
- Renamed {Add/Remove}Peer β†’ On{New/Closed}OutboundStream
- partialmessages: init fanout if empty (#690)
- Log errors when handling RPC in extensions (#668)
- Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages
- Added Rpc.From()
- Threadsafe dynamic direct peer management for GossipSub (#673).
MarcoPolo added a commit that referenced this pull request Apr 20, 2026
This release introduces support for the partial messages extension. The
partial messages extension gives the application precise control on
exchanging message metadata and exchanging parts of messages. Unlike
normal Gossipsub messages, Partial Messages are not opaque and peers can
exchange message metadata separately from message data. An example use
case is reconcilling when peers have some or all of a message. This
works in a backwards compatible way.

Notable changes:

- New FanoutOnly topic option (#676).
- WithMessageFilter to filter messages early in the notification pipeline (#678).

Fixes & improvements:

- Structured RPC logging
- Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first)
- Renamed {Add/Remove}Peer β†’ On{New/Closed}OutboundStream
- partialmessages: init fanout if empty (#690)
- Log errors when handling RPC in extensions (#668)
- Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages
- Added Rpc.From()
- Threadsafe dynamic direct peer management for GossipSub (#673).
MarcoPolo added a commit that referenced this pull request Apr 20, 2026
This release introduces support for the partial messages extension. The
partial messages extension gives the application precise control on
exchanging message metadata and exchanging parts of messages. Unlike
normal Gossipsub messages, Partial Messages are not opaque and peers can
exchange message metadata separately from message data. An example use
case is reconcilling when peers have some or all of a message. This
works in a backwards compatible way.

Notable changes:

- New FanoutOnly topic option (#676).
- WithMessageFilter to filter messages early in the notification pipeline (#678).

Fixes & improvements:

- Structured RPC logging
- Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first)
- Renamed {Add/Remove}Peer β†’ On{New/Closed}OutboundStream
- partialmessages: init fanout if empty (#690)
- Log errors when handling RPC in extensions (#668)
- Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages
- Added Rpc.From()
- Threadsafe dynamic direct peer management for GossipSub (#673).
MarcoPolo added a commit that referenced this pull request Apr 23, 2026
This release introduces support for the partial messages extension. The
partial messages extension gives the application precise control on
exchanging message metadata and exchanging parts of messages. Unlike
normal Gossipsub messages, Partial Messages are not opaque and peers can
exchange message metadata separately from message data. An example use
case is reconcilling when peers have some or all of a message. This
works in a backwards compatible way.

Notable changes:

- New FanoutOnly topic option (#676).
- WithMessageFilter to filter messages early in the notification
pipeline (#678).

Fixes & improvements:

- Structured RPC logging
- Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with
failing test first)
- Renamed {Add/Remove}Peer β†’ On{New/Closed}OutboundStream
- partialmessages: init fanout if empty (#690)
- Log errors when handling RPC in extensions (#668)
- Ensure Hello Packet is first RPC sent; set write deadline for outgoing
messages
- Added Rpc.From()
- Threadsafe dynamic direct peer management for GossipSub (#673).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants