Repository navigation
log on error when handling rpc in extensions - #668
Merged
Merged
Conversation
sukunrt
approved these changes
Feb 5, 2026
| gs.extensions.HandleRPC(rpc) | ||
| err := gs.extensions.HandleRPC(rpc) | ||
| if err != nil { | ||
| gs.logger.Warn("error in handling RPC", "err", err) |
Member
There was a problem hiding this comment.
if the rpc has from we can log more details.
MarcoPolo
force-pushed
the
push-trzlxpssuoly
branch
from
February 5, 2026 20:37
c4b05b4 to
1169bc3
Compare
MarcoPolo
added a commit
that referenced
this pull request
Apr 17, 2026
This release introduces support for the partial messages extension. The partial messages extension gives the application precise control on exchanging message metadata and exchanging parts of messages. Unlike normal Gossipsub messages, Partial Messages are not opaque and peers can exchange message metadata separately from message data. An example use case is reconcilling when peers have some or all of a message. This works in a backwards compatible way. Notable changes: - Message filter option β WithMessageFilter to filter messages early in the notification pipeline (#678). - Fanout-only topics β New FanoutOnly topic option (#676). - Dynamic direct peer handling β Threadsafe dynamic direct peer management for GossipSub (#673). Fixes & improvements: - Structured RPC logging - Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first) - Renamed {Add/Remove}Peer β On{New/Closed}OutboundStream - partialmessages: init fanout if empty (#690) - Log errors when handling RPC in extensions (#668) - Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages - Added Rpc.From()
MarcoPolo
added a commit
that referenced
this pull request
Apr 17, 2026
This release introduces support for the partial messages extension. The partial messages extension gives the application precise control on exchanging message metadata and exchanging parts of messages. Unlike normal Gossipsub messages, Partial Messages are not opaque and peers can exchange message metadata separately from message data. An example use case is reconcilling when peers have some or all of a message. This works in a backwards compatible way. Notable changes: - New FanoutOnly topic option (#676). - WithMessageFilter to filter messages early in the notification pipeline (#678). Fixes & improvements: - Structured RPC logging - Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first) - Renamed {Add/Remove}Peer β On{New/Closed}OutboundStream - partialmessages: init fanout if empty (#690) - Log errors when handling RPC in extensions (#668) - Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages - Added Rpc.From() - Threadsafe dynamic direct peer management for GossipSub (#673).
Merged
MarcoPolo
added a commit
that referenced
this pull request
Apr 18, 2026
This release introduces support for the partial messages extension. The partial messages extension gives the application precise control on exchanging message metadata and exchanging parts of messages. Unlike normal Gossipsub messages, Partial Messages are not opaque and peers can exchange message metadata separately from message data. An example use case is reconcilling when peers have some or all of a message. This works in a backwards compatible way. Notable changes: - New FanoutOnly topic option (#676). - WithMessageFilter to filter messages early in the notification pipeline (#678). Fixes & improvements: - Structured RPC logging - Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first) - Renamed {Add/Remove}Peer β On{New/Closed}OutboundStream - partialmessages: init fanout if empty (#690) - Log errors when handling RPC in extensions (#668) - Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages - Added Rpc.From() - Threadsafe dynamic direct peer management for GossipSub (#673).
MarcoPolo
added a commit
that referenced
this pull request
Apr 20, 2026
This release introduces support for the partial messages extension. The partial messages extension gives the application precise control on exchanging message metadata and exchanging parts of messages. Unlike normal Gossipsub messages, Partial Messages are not opaque and peers can exchange message metadata separately from message data. An example use case is reconcilling when peers have some or all of a message. This works in a backwards compatible way. Notable changes: - New FanoutOnly topic option (#676). - WithMessageFilter to filter messages early in the notification pipeline (#678). Fixes & improvements: - Structured RPC logging - Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first) - Renamed {Add/Remove}Peer β On{New/Closed}OutboundStream - partialmessages: init fanout if empty (#690) - Log errors when handling RPC in extensions (#668) - Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages - Added Rpc.From() - Threadsafe dynamic direct peer management for GossipSub (#673).
MarcoPolo
added a commit
that referenced
this pull request
Apr 20, 2026
This release introduces support for the partial messages extension. The partial messages extension gives the application precise control on exchanging message metadata and exchanging parts of messages. Unlike normal Gossipsub messages, Partial Messages are not opaque and peers can exchange message metadata separately from message data. An example use case is reconcilling when peers have some or all of a message. This works in a backwards compatible way. Notable changes: - New FanoutOnly topic option (#676). - WithMessageFilter to filter messages early in the notification pipeline (#678). Fixes & improvements: - Structured RPC logging - Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first) - Renamed {Add/Remove}Peer β On{New/Closed}OutboundStream - partialmessages: init fanout if empty (#690) - Log errors when handling RPC in extensions (#668) - Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages - Added Rpc.From() - Threadsafe dynamic direct peer management for GossipSub (#673).
MarcoPolo
added a commit
that referenced
this pull request
Apr 23, 2026
This release introduces support for the partial messages extension. The partial messages extension gives the application precise control on exchanging message metadata and exchanging parts of messages. Unlike normal Gossipsub messages, Partial Messages are not opaque and peers can exchange message metadata separately from message data. An example use case is reconcilling when peers have some or all of a message. This works in a backwards compatible way. Notable changes: - New FanoutOnly topic option (#676). - WithMessageFilter to filter messages early in the notification pipeline (#678). Fixes & improvements: - Structured RPC logging - Fix leaked state with OnNewIncomingStream/OnClosedIncomingStream (with failing test first) - Renamed {Add/Remove}Peer β On{New/Closed}OutboundStream - partialmessages: init fanout if empty (#690) - Log errors when handling RPC in extensions (#668) - Ensure Hello Packet is first RPC sent; set write deadline for outgoing messages - Added Rpc.From() - Threadsafe dynamic direct peer management for GossipSub (#673).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.