Repository navigation
Refactor parts metadata - #669
Merged
Merged
Conversation
To optimize when we send PartsMetadata we need the metadata to do two things: - Get the union of two parts metadata. - Return if one parts metadata is a subset of another. This allows us to avoid sending our updated partsMetadata to the peer that gave us new data, as they can infer our updatedPartsMetadata.
sukunrt
approved these changes
Feb 2, 2026
MarcoPolo
force-pushed
the
refactor-partsMetadata
branch
from
February 3, 2026 16:11
4da181f to
15a568d
Compare
MarcoPolo
force-pushed
the
refactor-partsMetadata
branch
from
February 3, 2026 23:28
15a568d to
9085ee5
Compare
This was referenced Feb 4, 2026
sukunrt
reviewed
Feb 5, 2026
Comment on lines
+41
to
+42
| // Returns true if the object is a subset of B. | ||
| IsSubset(B PartsMetadata) bool |
Member
There was a problem hiding this comment.
NIT:
IsSubsetOf is clearer, I think.
MarcoPolo
added a commit
that referenced
this pull request
Feb 12, 2026
This reverts commit 63d7d8e.
MarcoPolo
added a commit
that referenced
this pull request
Feb 27, 2026
This reverts commit 63d7d8e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To optimize when we send PartsMetadata we need the metadata to do two
things:
This allows us to avoid sending our updated partsMetadata to the peer
that gave us new data, as they can infer our updatedPartsMetadata.