Repository navigation
chore: remove uuid dependency - #8633
Conversation
The legacy ER renderer (erRenderer.js) was the only uuid v5 consumer and is no longer loaded; erDiagram.ts uses erRenderer-unified. Remove it along with its spec and erMarkers.js, which only it used. The mindmap DB's random diagramId was always overwritten by the renderer with the SVG element id before layout, so drop it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 74e5ee8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
| Layer / File(s) | Summary |
|---|---|
Remove UUID generation from mindmap data packages/mermaid/src/diagrams/mindmap/mindmapDb.ts, packages/mermaid/package.json |
MindmapDB.getData() no longer returns a generated diagramId. The uuid dependency is removed. |
Remove the legacy ER renderer packages/mermaid/src/diagrams/er/erMarkers.js, packages/mermaid/src/diagrams/er/erRenderer.js, packages/mermaid/src/diagrams/er/erRenderer.spec.ts, .changeset/drop-uuid-dependency.md |
The ER marker and renderer modules and the generateId test are deleted. A patch Changeset records the removals. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Suggested reviewers: knsv
Merge Risk: 
Minimal · previous review 686f3
-
The dependency and legacy renderer removal do not establish a current production or build risk.
Pre-merge checks: 
5
-
Full details: Description check
-
Explanation
The description includes a summary, design decisions, test information, documentation status, and changeset confirmation. It explains the removal of the legacy ER renderer and the mindmap diagramId change. The issue reference is omitted, but this is non-critical.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
Finishing Touches: 💡 1
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8633 +/- ##
===========================================
- Coverage 83.79% 80.65% -3.14%
===========================================
Files 612 610 -2
Lines 59021 58788 -233
Branches 17859 18163 +304
===========================================
- Hits 49455 47417 -2038
- Misses 9173 10983 +1810
+ Partials 393 388 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Upstream release: https://github.com/mermaid-js/mermaid/releases/tag/mermaid%4012.3.0 Release notes: ### Minor Changes - [#8164](mermaid-js/mermaid#8164) [`592d0e4`](mermaid-js/mermaid@592d0e4) Thanks [@filipsajdak](https://github.com/filipsajdak)! - feat: add the open-arrow and hollow-circle edge markers, so a notation can tell two kinds of flow apart by whether the head is filled - [#8165](mermaid-js/mermaid#8165) [`5c8aa5d`](mermaid-js/mermaid@5c8aa5d) Thanks [@filipsajdak](https://github.com/filipsajdak)! - feat: add the BPMN element shapes - events, gateways, activities, data objects, data stores and text annotations - each reporting where a line meets what is drawn - [#8470](mermaid-js/mermaid#8470) [`692d22a`](mermaid-js/mermaid@692d22a) Thanks [@openmindednewby](https://github.com/openmindednewby)! - feat: flowchart edges accept a `step` number (`e1@{ step: 1 }`); a dot travels the edges in step order and loops, hidden under `prefers-reduced-motion` - [#8478](mermaid-js/mermaid#8478) [`56aa105`](mermaid-js/mermaid@56aa105) Thanks [@openmindednewby](https://github.com/openmindednewby)! - feat: add `flowchart.stepDuration` to set how many seconds each step of the flowchart step animation lasts - [#8479](mermaid-js/mermaid#8479) [`800f7ef`](mermaid-js/mermaid@800f7ef) Thanks [@openmindednewby](https://github.com/openmindednewby)! - feat: highlight the flowchart edge whose step is playing, in sync with the step animation dot - [#8480](mermaid-js/mermaid#8480) [`50d6294`](mermaid-js/mermaid@50d6294) Thanks [@openmindednewby](https://github.com/openmindednewby)! - feat: add `flowchart.stepNumbers` to show each step edge's number in a badge ### Patch Changes - [#8443](mermaid-js/mermaid#8443) [`2ff8286`](mermaid-js/mermaid@2ff8286) Thanks [@knsv-bot](https://github.com/knsv-bot)! - fix: agentflow renders the `a[/…/]` short form as an input instead of falling back to a task with a SHAPE_UNSUPPORTED warning - [#8661](mermaid-js/mermaid#8661) [`b200b27`](mermaid-js/mermaid@b200b27) Thanks [@pbrolin47](https://github.com/pbrolin47)! - fix: Bump DOMPurify to 3.4.17 to address GHSA-55q2-fjhq-7xh7 and GHSA-6688-9rhm-gjv2 - [#8633](mermaid-js/mermaid#8633) [`686f350`](mermaid-js/mermaid@686f350) Thanks [@sidharthv96](https://github.com/sidharthv96)! - chore: Remove the `uuid` dependency and the unused legacy ER diagram renderer - [#8661](mermaid-js/mermaid#8661) [`7eec083`](mermaid-js/mermaid@7eec083) Thanks [@pbrolin47](https://github.com/pbrolin47)! - fix: Stop an edge from a node inside a subgraph from crossing an edge from the subgraph itself to the same node with ELK 0.10+ (e.g. `outer --> a` with `da --> a`, or `three --> two` with `two --> c2`) - [#8532](mermaid-js/mermaid#8532) [`42d3760`](mermaid-js/mermaid@42d3760) Thanks [@Devehab](https://github.com/Devehab)! - fix: upgrade bundled elkjs from 0.9.3 to 0.12.0, which is licensed `EPL-2.0 OR GPL-3.0-or-later`, so GPL-3.0 projects can ship mermaid with ELK - [#8162](mermaid-js/mermaid#8162) [`d5ca27a`](mermaid-js/mermaid@d5ca27a) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): size a lane that holds a nested subgraph (TB drew it as an empty 0x0 box, and likewise an outer group holding lanes), and grow LR and RL lanes by the nested group's padding - [#8405](mermaid-js/mermaid#8405) [`b4299f2`](mermaid-js/mermaid@b4299f2) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix: do not draw a stray empty swimlane when a node is listed in two lanes, and warn about it and about a subgraph nested in a lane - [#8385](mermaid-js/mermaid#8385) [`37d0ace`](mermaid-js/mermaid@37d0ace) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): keep two arrowheads that land on one face of a node apart when a sibling edge is straightened - [#8385](mermaid-js/mermaid#8385) [`38e810a`](mermaid-js/mermaid@38e810a) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): an edge routed round the outside of a diamond now arrives at one of its vertices instead of ending in empty space beside it - [#8385](mermaid-js/mermaid#8385) [`25d7e31`](mermaid-js/mermaid@25d7e31) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): a second edge leaving a diamond on the same level as its target now leaves from a free vertex instead of running beside the first - [#8171](mermaid-js/mermaid#8171) [`a4750b4`](mermaid-js/mermaid@a4750b4) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix: dock a swimlane edge on the shape it points at, so a line reaches an event's ring instead of stopping at the room its caption reserves - [#8385](mermaid-js/mermaid#8385) [`67315b9`](mermaid-js/mermaid@67315b9) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix: an edge label no longer pushes the nodes it joins a rank apart - [#8385](mermaid-js/mermaid#8385) [`21a1f5c`](mermaid-js/mermaid@21a1f5c) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): stop the crossing cleanup from joining two routes at a corner so they read as one line - [#8385](mermaid-js/mermaid#8385) [`e14bc3a`](mermaid-js/mermaid@e14bc3a) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): an edge no longer arrives at the vertex of a hexagon that another edge leaves from - [#8459](mermaid-js/mermaid#8459) [`edd162f`](mermaid-js/mermaid@edd162f) Thanks [@Yun-seoung](https://github.com/Yun-seoung)! - fix: Allow flowchart edge IDs regardless of whitespace after the node shape Edge IDs may no longer contain `[ ] ( ) { } |`. - [#8402](mermaid-js/mermaid#8402) [`4f2bade`](mermaid-js/mermaid@4f2bade) Thanks [@pcp-cmd](https://github.com/pcp-cmd)! - fix: Render use case include and extend relationship labels with UML guillemets. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: give me a 98K <240642031+inhuman-0@users.noreply.github.com>
Upstream release: https://github.com/mermaid-js/mermaid/releases/tag/mermaid%4012.3.0 Release notes: ### Minor Changes - [#8164](mermaid-js/mermaid#8164) [`592d0e4`](mermaid-js/mermaid@592d0e4) Thanks [@filipsajdak](https://github.com/filipsajdak)! - feat: add the open-arrow and hollow-circle edge markers, so a notation can tell two kinds of flow apart by whether the head is filled - [#8165](mermaid-js/mermaid#8165) [`5c8aa5d`](mermaid-js/mermaid@5c8aa5d) Thanks [@filipsajdak](https://github.com/filipsajdak)! - feat: add the BPMN element shapes - events, gateways, activities, data objects, data stores and text annotations - each reporting where a line meets what is drawn - [#8470](mermaid-js/mermaid#8470) [`692d22a`](mermaid-js/mermaid@692d22a) Thanks [@openmindednewby](https://github.com/openmindednewby)! - feat: flowchart edges accept a `step` number (`e1@{ step: 1 }`); a dot travels the edges in step order and loops, hidden under `prefers-reduced-motion` - [#8478](mermaid-js/mermaid#8478) [`56aa105`](mermaid-js/mermaid@56aa105) Thanks [@openmindednewby](https://github.com/openmindednewby)! - feat: add `flowchart.stepDuration` to set how many seconds each step of the flowchart step animation lasts - [#8479](mermaid-js/mermaid#8479) [`800f7ef`](mermaid-js/mermaid@800f7ef) Thanks [@openmindednewby](https://github.com/openmindednewby)! - feat: highlight the flowchart edge whose step is playing, in sync with the step animation dot - [#8480](mermaid-js/mermaid#8480) [`50d6294`](mermaid-js/mermaid@50d6294) Thanks [@openmindednewby](https://github.com/openmindednewby)! - feat: add `flowchart.stepNumbers` to show each step edge's number in a badge ### Patch Changes - [#8443](mermaid-js/mermaid#8443) [`2ff8286`](mermaid-js/mermaid@2ff8286) Thanks [@knsv-bot](https://github.com/knsv-bot)! - fix: agentflow renders the `a[/…/]` short form as an input instead of falling back to a task with a SHAPE_UNSUPPORTED warning - [#8661](mermaid-js/mermaid#8661) [`b200b27`](mermaid-js/mermaid@b200b27) Thanks [@pbrolin47](https://github.com/pbrolin47)! - fix: Bump DOMPurify to 3.4.17 to address GHSA-55q2-fjhq-7xh7 and GHSA-6688-9rhm-gjv2 - [#8633](mermaid-js/mermaid#8633) [`686f350`](mermaid-js/mermaid@686f350) Thanks [@sidharthv96](https://github.com/sidharthv96)! - chore: Remove the `uuid` dependency and the unused legacy ER diagram renderer - [#8661](mermaid-js/mermaid#8661) [`7eec083`](mermaid-js/mermaid@7eec083) Thanks [@pbrolin47](https://github.com/pbrolin47)! - fix: Stop an edge from a node inside a subgraph from crossing an edge from the subgraph itself to the same node with ELK 0.10+ (e.g. `outer --> a` with `da --> a`, or `three --> two` with `two --> c2`) - [#8532](mermaid-js/mermaid#8532) [`42d3760`](mermaid-js/mermaid@42d3760) Thanks [@Devehab](https://github.com/Devehab)! - fix: upgrade bundled elkjs from 0.9.3 to 0.12.0, which is licensed `EPL-2.0 OR GPL-3.0-or-later`, so GPL-3.0 projects can ship mermaid with ELK - [#8162](mermaid-js/mermaid#8162) [`d5ca27a`](mermaid-js/mermaid@d5ca27a) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): size a lane that holds a nested subgraph (TB drew it as an empty 0x0 box, and likewise an outer group holding lanes), and grow LR and RL lanes by the nested group's padding - [#8405](mermaid-js/mermaid#8405) [`b4299f2`](mermaid-js/mermaid@b4299f2) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix: do not draw a stray empty swimlane when a node is listed in two lanes, and warn about it and about a subgraph nested in a lane - [#8385](mermaid-js/mermaid#8385) [`37d0ace`](mermaid-js/mermaid@37d0ace) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): keep two arrowheads that land on one face of a node apart when a sibling edge is straightened - [#8385](mermaid-js/mermaid#8385) [`38e810a`](mermaid-js/mermaid@38e810a) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): an edge routed round the outside of a diamond now arrives at one of its vertices instead of ending in empty space beside it - [#8385](mermaid-js/mermaid#8385) [`25d7e31`](mermaid-js/mermaid@25d7e31) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): a second edge leaving a diamond on the same level as its target now leaves from a free vertex instead of running beside the first - [#8171](mermaid-js/mermaid#8171) [`a4750b4`](mermaid-js/mermaid@a4750b4) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix: dock a swimlane edge on the shape it points at, so a line reaches an event's ring instead of stopping at the room its caption reserves - [#8385](mermaid-js/mermaid#8385) [`67315b9`](mermaid-js/mermaid@67315b9) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix: an edge label no longer pushes the nodes it joins a rank apart - [#8385](mermaid-js/mermaid#8385) [`21a1f5c`](mermaid-js/mermaid@21a1f5c) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): stop the crossing cleanup from joining two routes at a corner so they read as one line - [#8385](mermaid-js/mermaid#8385) [`e14bc3a`](mermaid-js/mermaid@e14bc3a) Thanks [@filipsajdak](https://github.com/filipsajdak)! - fix(swimlanes): an edge no longer arrives at the vertex of a hexagon that another edge leaves from - [#8459](mermaid-js/mermaid#8459) [`edd162f`](mermaid-js/mermaid@edd162f) Thanks [@Yun-seoung](https://github.com/Yun-seoung)! - fix: Allow flowchart edge IDs regardless of whitespace after the node shape Edge IDs may no longer contain `[ ] ( ) { } |`. - [#8402](mermaid-js/mermaid#8402) [`4f2bade`](mermaid-js/mermaid@4f2bade) Thanks [@pcp-cmd](https://github.com/pcp-cmd)! - fix: Render use case include and extend relationship labels with UML guillemets. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: give me a 98K <240642031+inhuman-0@users.noreply.github.com>
📑 Summary
Removes
uuidfrom mermaid's runtime dependencies.diagrams/er/erRenderer.jswas the onlyuuidv5 consumer, but nothing loads it:erDiagram.tsuseserRenderer-unified, and only its own spec imported it. Removed it together witherRenderer.spec.tsanderMarkers.js(only imported by that renderer).diagramId.MindmapDB.getData()setdiagramId: 'mindmap-' + v4(), butmindmapRenderer.tsoverwrites it with the SVG element id before callingrender(), which is the first placediagramIdis read. The field is optional onLayoutData, so the placeholder is dropped. Multiple mindmaps on a page stay isolated through the per-render SVG id, the same as flowchart, class, state and ER.uuid@14entries are removed.uuid@8.3.2remains as a transitive dependency of other packages.📏 Design Decisions
No replacement random-id helper was needed: the only remaining
v4()value was never observed by any consumer.📋 Tasks
Make sure you
pnpm changesetand following the prompts.🤖 Generated with Claude Code
Summary
uuidfrom Mermaid’s runtime dependencies and adds a patch changeset.erMarkers.js. The active ER diagram path importserRenderer-unified.js.diagramIdand itsuuidv4 import from the mindmap database. The mindmap renderer assigns the SVG element ID todata4Layout.diagramId.uuid@8.3.2in the lockfile as a transitive dependency.Tests
The PR description reports that the existing mindmap and ER unit tests pass: 70 files and 2,470 tests. This result was not independently verified.