Repository navigation
Conversation
shakuzen
force-pushed
the
concurrent-keyvalues-modification
branch
from
December 10, 2024 08:53
3cf9063 to
fd01cfb
Compare
shakuzen
commented
Dec 10, 2024
| dependencies { | ||
| implementation project(":micrometer-core") | ||
| // implementation("io.micrometer:micrometer-core:1.12.4") | ||
| implementation project(":micrometer-test") |
Member
Author
There was a problem hiding this comment.
This dependency was causing a weird ClassNotFoundException when running jcstress from IntelliJ, but it is only here for the @Issue annotation. We do not do any processing of the annotation, so I'm not sure there's any more value of it being an actual annotation vs a comment - I've commented it out where it was used in this module.
shakuzen
commented
Dec 10, 2024
| @Benchmark | ||
| @Group("contended") | ||
| @GroupThreads(1) | ||
| public KeyValues contendedRead() { |
Member
Author
There was a problem hiding this comment.
The contended group will share the threads configured for the benchmark in proportion to the specified @GroupThreads. So in this current setup there will be two execution groups for contended, each with 2 threads, one thread reading and one thread writing concurrently.
shakuzen
force-pushed
the
concurrent-keyvalues-modification
branch
from
December 10, 2024 08:59
fd01cfb to
a6b2eb1
Compare
This avoids the issues with concurrent reads and writes of the keyvalues on the Context. Reverts the previous change to KeyValues as it is not needed with CHM.
shakuzen
force-pushed
the
concurrent-keyvalues-modification
branch
from
December 10, 2024 09:07
a6b2eb1 to
d057a34
Compare
This was referenced Dec 10, 2024
shakuzen
added a commit
that referenced
this pull request
Dec 12, 2024
This scenario produced a NPE before the change from using a LinkedHashMap to ConcurrentHashMap. See gh-5739
Member
Author
|
I added a jcstress test for concurrent get/remove on a keyvalue (503f2e9), as this scenario was producing the NPE reported in the linked issue. |
Member
Author
|
And sharing benchmark results from my machine (MBP M1). There was not much of a noticeable difference and at the level of nanoseconds, the run-to-run results can vary as much as the differences here. With these changes using ConcurrentHashMap: Before these changes (1.14.1) using LinkedHashMap: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4356 and micrometer-metrics/tracing#898.