Repository navigation
DRIVERS-3114 Remove unified spec test behaviors only used by Astrolabe. - #1809
Conversation
alcaeus
left a comment
There was a problem hiding this comment.
I believe this is the first time we're trying to remove functionality from the unified test format (I previously only deprecated the serverless option in runOnRequirements). While we never specified whether the test format follows something like semantic versioning, so far the assumption has held true that a test file that validates in schema version 1.x will validate in any schema version 1.y where y > x. This change would break that previous assumption. On the other hand, IIRC there are no tests other than astrolabe test files that use either loop or storeEventsAsEntities functionality, so removing the functionality from the schema would allow drivers to remove the logic from their test runners without fear of other tests re-introducing them.
|
@alcaeus My preference would be to remove any unused code because:
Could your concerns be resolved by bumping to schema version 2.0? Seems like the right use of a major version 🙂 |
|
Another option is to remove the requirement to implement those behaviors from the Unified Test Format spec, but leave the properties in the JSON schema (with a note about why they're not in the spec). That would maintain the existing compatibility but allow teams to remove (or ignore) those behaviors from their unified test runners. Additionally, JSON Schema draft 2019-09 adds a new "deprecated" property. We could consider using the newer JSON Schema and mark the unused properties as |
42012de to
ffb5dea
Compare
|
Updated the PR to bump JSON Schema to draft 2019-09 for schema 1.24, and deprecated the |
DRIVERS-3114
We're sunsetting the Drivers Atlas Testing (Astrolabe) project. Some unified spec test behaviors are only used by Astrolabe and can be removed:
storeEventsAsEntitiesoption for client entitiesloopoperationChanges:
storeEventsAsEntitiesoption for client entities andloopoperation from the Unified Test Format spec.schema-latest.json.Please complete the following before merging:
clusters).