Repository navigation
Remove isIndyModule method - #19140
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the deprecated InstrumentationModule#isIndyModule() hook from the javaagent extension API, aligning the extension surface with the current โindy vs inlinedโ selection being agent-driven rather than per-module.
Changes:
- Deleted the deprecated
InstrumentationModule#isIndyModule()method and its associated Javadoc from the extension API.
| /** Register resource names to inject into the user's class loader. */ | ||
| public void registerHelperResources(HelperResourceBuilder helperResourceBuilder) {} |
|
This PR has review comments. Review suggestions, whether from maintainers or automated reviewers, aren't always correct or required. Please evaluate each comment on its merits, then make sure each thread has a clear outcome. For example, link to the commit if you applied a suggestion, explain why it wasn't applied, or ask a follow-up question. Automation flags a PR for human review once every review thread has a reply or is marked as resolved. Status across open PRs is visible on the pull request dashboard. |
cd78a27 to
c5c4e8f
Compare
There are still references to in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/contributing/writing-instrumentation-module.md these should get removed in #19076