Skip to content

Remove isIndyModule method - #19140

Merged
trask merged 2 commits into
open-telemetry:mainfrom
laurit:remove-isIndyModule
Jul 15, 2026
Merged

trask merged 2 commits into
open-telemetry:mainfrom
laurit:remove-isIndyModule

Conversation

@laurit

@laurit laurit commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings July 7, 2026 13:34
@laurit
laurit requested a review from a team as a code owner July 7, 2026 13:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated InstrumentationModule#isIndyModule() hook from the javaagent extension API, aligning the extension surface with the current โ€œindy vs inlinedโ€ selection being agent-driven rather than per-module.

Changes:

  • Deleted the deprecated InstrumentationModule#isIndyModule() method and its associated Javadoc from the extension API.

Comment on lines 119 to 120
/** Register resource names to inject into the user's class loader. */
public void registerHelperResources(HelperResourceBuilder helperResourceBuilder) {}
@opentelemetry-pr-dashboard

Copy link
Copy Markdown

This PR has review comments. Review suggestions, whether from maintainers or automated reviewers, aren't always correct or required. Please evaluate each comment on its merits, then make sure each thread has a clear outcome.

For example, link to the commit if you applied a suggestion, explain why it wasn't applied, or ask a follow-up question.

Automation flags a PR for human review once every review thread has a reply or is marked as resolved.

Status across open PRs is visible on the pull request dashboard.

@trask trask added this to the v2.30.0 milestone Jul 9, 2026

@trask trask left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to update the docs since I think the docs in #19076 are targeted for 3.0 release (not 2.30)

(I removed this)

@trask
trask force-pushed the remove-isIndyModule branch from cd78a27 to c5c4e8f Compare July 15, 2026 17:55
@trask
trask enabled auto-merge (squash) July 15, 2026 17:55
@trask
trask merged commit 9889118 into open-telemetry:main Jul 15, 2026
191 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants