Skip to content

Fix 404 on template type attributes - #1240

Merged
jerbly merged 1 commit into
open-telemetry:mainfrom
jerbly:fix-template-type-get-api
Feb 25, 2026
Merged

jerbly merged 1 commit into
open-telemetry:mainfrom
jerbly:fix-template-type-get-api

Conversation

@jerbly

@jerbly jerbly commented Feb 24, 2026

Copy link
Copy Markdown
Member

Fixed a bug in the serve api. Attempts to get a template-type attribute would return a 404.

@jerbly
jerbly requested a review from a team as a code owner February 24, 2026 14:12
@codecov

codecov Bot commented Feb 24, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 80.4%. Comparing base (0c7d696) to head (bf78d18).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1240   +/-   ##
=====================================
  Coverage   80.4%   80.4%           
=====================================
  Files        110     110           
  Lines       8984    8984           
=====================================
  Hits        7225    7225           
  Misses      1759    1759           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/serve/handlers.rs
// O(1) lookup via SearchContext
match state.search_ctx.get_attribute(key) {
// O(1) lookup via SearchContext, checking both regular and template attributes
match state

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we had tests for the API in the future.

@jerbly
jerbly merged commit 4a920c1 into open-telemetry:main Feb 25, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants