Repository navigation
fix(oci): skip digest-named directories during GC - #1526
Merged
Merged
Conversation
Signed-off-by: yusheng.wang <yusheng.wang@chaitin.com>
wangyusheng1985
requested review from
TerryHowe,
Wwwsylvia,
sabre1041 and
shizhMSFT
as code owners
October 9, 2026 19:45
TerryHowe
reviewed
Oct 10, 2026
Codecov Reportโ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1526 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 103 103
Lines 8463 8465 +2
=======================================
+ Hits 7798 7800 +2
Misses 654 654
Partials 11 11 โ View full report in Codecov by Harness. ๐ New features to boost your workflow:
|
TerryHowe
requested changes
Oct 13, 2026
TerryHowe
left a comment
TerryHowe
left a comment
Member
There was a problem hiding this comment.
See inline comments, thanks!
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
TerryHowe
reviewed
Oct 14, 2026
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Closed
TerryHowe
pushed a commit
that referenced
this pull request
Oct 15, 2026
Backport of #1526 to v2. Store.GC skipped directories under blobs/ but not under blobs/<alg>/, so a directory named like a digest reached os.Remove, which fails on a non-empty directory and aborts GC. GC now skips those directories, and os.Remove errors include the blob path. Fixes #1579 Signed-off-by: Gaurav Jadhav <gaurav.vjadhav01@gmail.com>
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1525.
Store.GCskipped directories underblobs/but not underblobs/<alg>/. A directory whose name looks like a digest then reachedos.Remove, which failed on a non-empty directory and aborted GC.GC now skips those directories, and
os.Removeerrors include the path.