Skip to content

Isolate Preact options during async renders - #471

Merged
JoviDeCroock merged 2 commits into
mainfrom
fix/async-options-concurrency
Aug 30, 2026
Merged

JoviDeCroock merged 2 commits into
mainfrom
fix/async-options-concurrency

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

Summary

  • capture Preact option hooks in per-render state so Suspense resumptions keep using the hooks active when rendering started
  • scope options._skipEffects to synchronous render work so suspended and overlapping renders do not leak or restore stale global state
  • use the captured hooks consistently for root, commit, unmount, and error handling

@changeset-bot

changeset-bot Bot commented Aug 22, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 74bd777

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-render-to-string Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock
JoviDeCroock marked this pull request as ready for review August 23, 2026 05:54
@JoviDeCroock
JoviDeCroock merged commit 005230b into main Aug 30, 2026
1 check passed
@JoviDeCroock
JoviDeCroock deleted the fix/async-options-concurrency branch August 30, 2026 12:14
@github-actions github-actions Bot mentioned this pull request Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant