[yangbodong22011]

fixes #3349
fixes #3350

Since our Tuple class doesn't support <Long, Double> pairs, I chose KeyValue, but it's worth discussing.

Or we can consider changing the current Tuple to Tuple<K,V>.

[codecov-commenter]

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.12 ⚠️

Comparison is base (8b60f29) 67.30% compared to head (937ec6e) 67.19%.

❗ Current head 937ec6e differs from pull request most recent head c15a778. Consider uploading reports for the commit c15a778 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3364      +/-   ##
============================================
- Coverage     67.30%   67.19%   -0.12%     
- Complexity     4722     4725       +3     
============================================
  Files           269      269              
  Lines         15239    15273      +34     
  Branches        963      964       +1     
============================================
+ Hits          10256    10262       +6     
- Misses         4563     4589      +26     
- Partials        420      422       +2     

Impacted Files	Coverage Δ
...ava/redis/clients/jedis/MultiNodePipelineBase.java	21.53% <0.00%> (-0.10%)	⬇️
src/main/java/redis/clients/jedis/Pipeline.java	17.02% <0.00%> (-0.08%)	⬇️
...main/java/redis/clients/jedis/TransactionBase.java	11.83% <0.00%> (-0.06%)	⬇️
...lients/jedis/commands/SortedSetBinaryCommands.java	100.00% <ø> (ø)
...edis/clients/jedis/commands/SortedSetCommands.java	100.00% <ø> (ø)
...edis/commands/SortedSetPipelineBinaryCommands.java	0.00% <ø> (ø)
...ents/jedis/commands/SortedSetPipelineCommands.java	0.00% <ø> (ø)
.../main/java/redis/clients/jedis/CommandObjects.java	84.83% <50.00%> (-0.11%)	⬇️
src/main/java/redis/clients/jedis/Jedis.java	84.76% <50.00%> (-0.14%)	⬇️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java	74.27% <50.00%> (-0.10%)	⬇️
... and 2 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sazzad16]

we can consider changing the current Tuple to Tuple<K,V>.

This is one of the best thing we can do. But sadly it'd be a breaking change 😞

Since our Tuple class doesn't support <Long, Double> pairs, I chose KeyValue, but it's worth discussing.

All I can think of is RankTuple which would be exactly Tuple but with rank instead of element. Given the circumstances, I'm okay with KeyValue for Jedis 4.

@dengliming WDYT?