Skip to content

build: install @types/express@^v5 as a dev dependency for express@^5 - #2355

Merged
zimeg merged 1 commit into
mainfrom
zimeg-build-express-types-v5
Dec 5, 2024
Merged

zimeg merged 1 commit into
mainfrom
zimeg-build-express-types-v5

Conversation

@zimeg

@zimeg zimeg commented Dec 4, 2024

Copy link
Copy Markdown
Member

Summary

This PR bumps @types/express to v5 to match the included express v5 package. These typings are also moved into the devDependencies since these are required for just the build step AFAIK! Fixes #2354.

Requirements

@zimeg zimeg added semver:patch dependencies Pull requests that update a dependency file labels Dec 4, 2024
@zimeg zimeg added this to the 4.1.2 milestone Dec 4, 2024
@zimeg
zimeg requested review from a team and seratch December 4, 2024 20:23
@zimeg zimeg self-assigned this Dec 4, 2024
@codecov

codecov Bot commented Dec 4, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 92.59%. Comparing base (606b243) to head (b8d66fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2355   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@zimeg

zimeg commented Dec 4, 2024

Copy link
Copy Markdown
Member Author

It's curious that @dependabot didn't catch this in the last round of updates... We seem to include just a handful of dependencies in this list, but I'm wondering if we want to revisit this?

https://github.com/slackapi/bolt-js/blob/main/.github/dependabot.yml

@seratch seratch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; LGTM

@seratch

seratch commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

@zimeg Yeah, we can add more dependencies to the list. At least, having @types/* should be fine

@zimeg

zimeg commented Dec 5, 2024

Copy link
Copy Markdown
Member Author

@seratch Thanks! And adding some dependencies sounds good. πŸš€

It makes sense that express is kept at a minimum 5.0.0 IMO to avoid requiring updates across all dependencies of an app, but that might be interesting to revisit for keeping up with bug fixes and added features of bolt dependencies.

A combination of options for allow in this file seem promising for updating a select few more dependencies also: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow

Hoping to explore this more after thinking about versions a bit, but I'd love to know if you have immediate thoughts on these numbers πŸ™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file semver:patch TypeScript-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v4.1.1 has inconsistent types with express v5

2 participants