Skip to content
This repository was archived by the owner on Oct 29, 2026. It is now read-only.

misc(esbuild): Log warning when attempting to inject debug IDs with esbuild bundle option active - #526

Merged
lforst merged 2 commits into
mainfrom
lforst-warn-on-esbuild-bundle-option
May 3, 2024
Merged

lforst merged 2 commits into
mainfrom
lforst-warn-on-esbuild-bundle-option

Conversation

@lforst

@lforst lforst commented Apr 17, 2024

Copy link
Copy Markdown

Relates to: #445 (comment)

@lforst
lforst requested a review from Lms24 April 17, 2024 15:07
Comment thread packages/esbuild-plugin/src/index.ts Outdated
setup({ initialOptions, onLoad, onResolve }) {
if (initialOptions.bundle) {
logger.warn(
"Esbuild's `bundle` option is currently not supported! Esbuild will probably crash now."

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Did I understand the issue correctly that this only happens for bundle: true? In this case, maybe we tell users this specifically:

Suggested change
"Esbuild's `bundle` option is currently not supported! Esbuild will probably crash now."
"Esbuild's `bundle: true` option is currently not supported! Esbuild will probably crash now."

Also, is there anything we can recommend them here instead of just saying that their build will crash?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely valid point. I updated the wording!

@lforst
lforst requested a review from Lms24 April 19, 2024 11:43
@lforst

lforst commented May 3, 2024

Copy link
Copy Markdown
Author

@Lms24 would you mind taking another look?

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry this fell through. LGTM and thx for making the change!

@lforst
lforst merged commit fd2a99c into main May 3, 2024
@lforst
lforst deleted the lforst-warn-on-esbuild-bundle-option branch May 3, 2024 11:33
@pckilgore

Copy link
Copy Markdown
image image

I'm confused here cc @lforst

@lforst

lforst commented Jun 1, 2024

Copy link
Copy Markdown
Author

omg I think I completely flipped what I meant to do in that PR. Gonna fix it on monday.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants