This repository was archived by the owner on Oct 29, 2026. It is now read-only.
Repository navigation
feat: generate proto-only library - #2046
Merged
Merged
Conversation
Contributor
Author
|
I've test on three proto-only libraries:
It turns out that allydb connectors don't copy proto files to library. It has the same issue with 2 and I need to exclude |
JoeWang1127
marked this pull request as ready for review
September 28, 2023 13:51
JoeWang1127
requested review from
a team,
blakeli0,
diegomarquezp and
meltsufin
September 28, 2023 13:51
diegomarquezp
left a comment
Contributor
There was a problem hiding this comment.
do we want to add at least one of the proto-only libraries you mentioned in proto_path_list.txt?
Contributor
Author
Good idea. I added |
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! |
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! |
|
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed! |
diegomarquezp
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fix #2047.