Skip to content

fix(expect): remove @types/node from dependencies - #14385

Merged
SimenB merged 3 commits into
jestjs:mainfrom
dmitri-gb:remove-types-node-from-expect
Aug 16, 2023
Merged

SimenB merged 3 commits into
jestjs:mainfrom
dmitri-gb:remove-types-node-from-expect

Conversation

@dmitri-gb

@dmitri-gb dmitri-gb commented Aug 3, 2023 •

Copy link
Copy Markdown
Contributor

Summary

Remove @types/node from dependencies of expect. This package can be used in non-Node.js environments.

The dependency was introduced in #14139.

@netlify

netlify Bot commented Aug 3, 2023 •

Copy link
Copy Markdown

βœ… Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 72bf413
πŸ” Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64db3687c22a3100077e535d
😎 Deploy Preview https://deploy-preview-14385--jestjs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dmitri-gb dmitri-gb changed the title fix(expect): remove dependency on a Node.js module fix(expect): remove @types/node from dependencies Aug 3, 2023
Comment on lines -61 to +60
currentConcurrentTestName?: AsyncLocalStorage<string>;
currentConcurrentTestName?: () => string | undefined;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like breaking change, or?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Not sure if it's breaking enough, tho... πŸ˜…

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, breaking for anyone that calls jestExpect.setState with this property or anyone that reads it inside a custom matcher. Since the property was only added in v29.6.0 then I'm pretty sure only Jest itself does that πŸ˜…

@SimenB

SimenB commented Aug 21, 2023

Copy link
Copy Markdown
Member

@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "expect" package now imports @types/node causing web projects to break

3 participants