Skip to content

feat(js): add swc cli options --strip-leading-paths - #22193

Merged
jaysoo merged 3 commits into
nrwl:masterfrom
hongxuWei:master
Apr 11, 2024
Merged

jaysoo merged 3 commits into
nrwl:masterfrom
hongxuWei:master

Conversation

@hongxuWei

@hongxuWei hongxuWei commented Mar 7, 2024 •

Copy link
Copy Markdown
Contributor

Current Behavior

can't pass the cli options --strip-leading-paths to swc executor

Expected Behavior

add a config stripLeadingPaths pass through to cli options

Related Issue(s)

Fixes #22361

@hongxuWei
hongxuWei requested review from a team as code owners March 7, 2024 02:41
@hongxuWei
hongxuWei requested review from jaysoo and leosvelperez March 7, 2024 02:41
@vercel

vercel Bot commented Mar 7, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 10, 2024 9:46pm

@hongxuWei

Copy link
Copy Markdown
Contributor Author

@jaysoo @leosvelperez
Please check this pull request~

@jaysoo

jaysoo commented Apr 5, 2024

Copy link
Copy Markdown
Member

@hongxuWei Thanks, the @swc/cli needs to be updated as well to support the option. Once the CI is green it'll be merged.

@jaysoo

jaysoo commented Apr 5, 2024

Copy link
Copy Markdown
Member

The new @swc/cli version is causing dist to generate differently. Need to debug and fix.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 17, 2024

This branch was successfully deployed

1 active deployment
Preview — dcd676e3 Deployed Apr 10, 2024 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

swc cli options --strip-leading-paths

2 participants