Skip to content

fix(core): fix plugin exclude option - #22738

Merged
Coly010 merged 2 commits into
nrwl:masterfrom
yjaaidi:fix/fix-plugin-exclude-option
Apr 9, 2024
Merged

Coly010 merged 2 commits into
nrwl:masterfrom
yjaaidi:fix/fix-plugin-exclude-option

Conversation

@yjaaidi

@yjaaidi yjaaidi commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

Current Behavior

Using plugins' exclude option crashes.

Expected Behavior

Plugins' exclude option should exclude files matching given patterns.

Related Issue(s)

Fixes #22737

@yjaaidi
yjaaidi requested a review from a team as a code owner April 9, 2024 08:29
@yjaaidi
yjaaidi requested a review from xiongemi April 9, 2024 08:29
@vercel

vercel Bot commented Apr 9, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Updated (UTC)
nx-dev โœ… Ready (Inspect) Visit Preview Apr 9, 2024 8:39pm

@yjaaidi
yjaaidi force-pushed the fix/fix-plugin-exclude-option branch from 6fa09fe to 332c2b1 Compare April 9, 2024 15:19

@FrozenPandaz FrozenPandaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM ๐ŸŽ‰

Can you get CI to pass please?

@yjaaidi
yjaaidi force-pushed the fix/fix-plugin-exclude-option branch from 332c2b1 to cc77e0e Compare April 9, 2024 19:41
@Coly010
Coly010 merged commit caf663f into nrwl:master Apr 9, 2024
@yjaaidi
yjaaidi deleted the fix/fix-plugin-exclude-option branch April 9, 2024 22:27
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 15, 2024

This branch was successfully deployed

1 active deployment
Preview โ€” 8cf5b433 Deployed Apr 9, 2024 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nx.json option plugins.[].exclude crashes

4 participants