Skip to content

feat(js): add swc cli options --strip-leading-paths - #22856

Merged
jaysoo merged 1 commit into
masterfrom
swc_cli_update
Apr 17, 2024
Merged

jaysoo merged 1 commit into
masterfrom
swc_cli_update

Conversation

@jaysoo

@jaysoo jaysoo commented Apr 17, 2024

Copy link
Copy Markdown
Member

This PR updates SWC CLI for Nx 19 to support --strip-leading-paths CLI option.

It is a revert of this PR but with updated migration targeting Nx 19.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo
jaysoo requested review from a team as code owners April 17, 2024 14:19
@jaysoo
jaysoo requested review from Coly010 and juristr April 17, 2024 14:19
@vercel

vercel Bot commented Apr 17, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Updated (UTC)
nx-dev โœ… Ready (Inspect) Visit Preview Apr 17, 2024 2:23pm

@jaysoo
jaysoo merged commit 701c513 into master Apr 17, 2024
@jaysoo
jaysoo deleted the swc_cli_update branch April 17, 2024 18:18
@wjehring

Copy link
Copy Markdown

@jaysoo - I've been following the external option with interest, sad to see it's been deprecated. Any chance you can give me some insight into the reasons for discontinuing it? Thanks!

@github-actions

github-actions Bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2024
@jaysoo

jaysoo commented May 15, 2024

Copy link
Copy Markdown
Member Author

@wjehring It is going against what TSC/SWC are supposed to do, just simply transpile files. The experimental feature has proven tricky to support in different scenarios, and we'd rather focus our attention elsewhere.

Feel free to open a discussion about it in the the Discussions tab, maybe we can address the problems properly without the current unstable feature.

This branch was successfully deployed

1 active deployment
Preview โ€” 73e69c4a Deployed Apr 17, 2024 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants