Skip to content

fix(gradle): change gradle command to be relative path - #22963

Merged
FrozenPandaz merged 1 commit into
nrwl:masterfrom
xiongemi:feature/nxc-592-use-relative-path-for-gradle-command
Apr 23, 2024
Merged

FrozenPandaz merged 1 commit into
nrwl:masterfrom
xiongemi:feature/nxc-592-use-relative-path-for-gradle-command

Conversation

@xiongemi

Copy link
Copy Markdown
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi
xiongemi requested a review from FrozenPandaz as a code owner April 23, 2024 19:15
@vercel

vercel Bot commented Apr 23, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev โฌœ๏ธ Ignored (Inspect) Visit Preview Apr 23, 2024 8:35pm

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const graldeFile = getGradleFile();
const gradleFile = getGradleFile();

Comment thread packages/gradle/src/plugin/nodes.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep projectRoot and get a relative path from projectRoot to gradleFile?

Moving to the workspaceRoot would break the command for nested projects.

@xiongemi
xiongemi force-pushed the feature/nxc-592-use-relative-path-for-gradle-command branch 4 times, most recently from 06d0221 to 2333ce3 Compare April 23, 2024 20:24
Comment on lines 37 to 39

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there was anything wrong this. Can you bring it back please?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this check is a part of getGradleBinaryPath function, which got called before this line. i don't think we need this

@xiongemi
xiongemi force-pushed the feature/nxc-592-use-relative-path-for-gradle-command branch from 2333ce3 to 00b8df0 Compare April 23, 2024 20:33
@FrozenPandaz
FrozenPandaz merged commit 99e5c86 into nrwl:master Apr 23, 2024
FrozenPandaz pushed a commit that referenced this pull request Apr 25, 2024
@github-actions

github-actions Bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants