Skip to content

fix(nextjs): Moving a library using @nx/workspace:move should update … - #23311

Merged
ndcunningham merged 1 commit into
masterfrom
fix/nextjs-move-library
May 13, 2024
Merged

ndcunningham merged 1 commit into
masterfrom
fix/nextjs-move-library

Conversation

@ndcunningham

Copy link
Copy Markdown
Contributor

Current

When you using @nx/workspace:move after create a Next.js library the server path remains unchanged.

Expected

The server path is changed as well as the main entry point for the library path.

Fixes: #20821

@ndcunningham
ndcunningham requested a review from a team as a code owner May 10, 2024 18:28
@ndcunningham
ndcunningham requested a review from xiongemi May 10, 2024 18:28
@vercel

vercel Bot commented May 10, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 3:05pm

@ndcunningham ndcunningham self-assigned this May 10, 2024
@ndcunningham
ndcunningham force-pushed the fix/nextjs-move-library branch from e0c42b9 to f86065e Compare May 10, 2024 19:21
@ndcunningham
ndcunningham force-pushed the fix/nextjs-move-library branch from f86065e to a786947 Compare May 13, 2024 15:01
@ndcunningham
ndcunningham force-pushed the fix/nextjs-move-library branch from a786947 to e488262 Compare May 13, 2024 15:03
@ndcunningham
ndcunningham merged commit d879279 into master May 13, 2024
@ndcunningham
ndcunningham deleted the fix/nextjs-move-library branch May 13, 2024 18:48
FrozenPandaz pushed a commit that referenced this pull request May 14, 2024
#23311)

## Current
When you using `@nx/workspace:move` after create a Next.js library the
server path remains unchanged.

## Expected
The server path is changed as well as the main entry point for the
library path.

Fixes: #20821
(cherry picked from commit d879279)
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renaming/Moving NextJS library with @nx/workspace:move doesn't work for the server import path

3 participants