Repository navigation
fix(storybook): should handle inferred cypress when generating cypress project #21770 - #23327
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 07fa0fb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
approved these changes
May 13, 2024
Coly010
force-pushed
the
fix-storybook-cypress-project
branch
from
May 13, 2024 14:49
9de68c3 to
62342b4
Compare
Coly010
force-pushed
the
fix-storybook-cypress-project
branch
from
May 13, 2024 14:51
62342b4 to
07fa0fb
Compare
mandarini
approved these changes
May 13, 2024
isaacplmann
approved these changes
May 13, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 13, 2024
…s project #21770 (#23327) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> The `@nx/storybook:cypress-project` generator expects there to be a defined target for e2e target. However, since the introduction of inference, this may not be the case. This results in the generator erroring ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The `@nx/storybook:cypress-project` generator should handle inference and generate an appropriate cypress.config.ts file ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #21770 (cherry picked from commit 61129f4)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/storybook:cypress-projectgenerator expects there to be a defined target for e2e target.However, since the introduction of inference, this may not be the case.
This results in the generator erroring
Expected Behavior
The
@nx/storybook:cypress-projectgenerator should handle inference and generate an appropriate cypress.config.ts fileRelated Issue(s)
Fixes #21770