Skip to content

fix(core): fix affected detection for inputs after named inputs - #23354

Merged
FrozenPandaz merged 1 commit into
masterfrom
fix/affected-inputs
May 15, 2024
Merged

FrozenPandaz merged 1 commit into
masterfrom
fix/affected-inputs

Conversation

@FrozenPandaz

Copy link
Copy Markdown
Contributor

Current Behavior

Inputs after named inputs are not considered for affected.

Expected Behavior

Inputs after named inputs are considered for affected...

Related Issue(s)

Fixes #

@FrozenPandaz
FrozenPandaz requested a review from a team as a code owner May 13, 2024 20:58
@FrozenPandaz
FrozenPandaz requested a review from AgentEnder May 13, 2024 20:58
@vercel

vercel Bot commented May 13, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev โฌœ๏ธ Ignored (Inspect) Visit Preview May 14, 2024 11:29pm

@FrozenPandaz FrozenPandaz self-assigned this May 13, 2024
@FrozenPandaz
FrozenPandaz force-pushed the fix/affected-inputs branch 2 times, most recently from a293ad7 to daf45bc Compare May 14, 2024 22:20
@FrozenPandaz
FrozenPandaz force-pushed the fix/affected-inputs branch from daf45bc to 8e6d765 Compare May 14, 2024 23:27
@FrozenPandaz
FrozenPandaz enabled auto-merge (squash) May 14, 2024 23:27
@FrozenPandaz
FrozenPandaz merged commit 722b2d0 into master May 15, 2024
@FrozenPandaz
FrozenPandaz deleted the fix/affected-inputs branch May 15, 2024 00:23
Coly010 pushed a commit that referenced this pull request May 15, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

Inputs after named inputs are not considered for affected.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Inputs after named inputs are considered for affected...

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
FrozenPandaz added a commit that referenced this pull request May 15, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

Inputs after named inputs are not considered for affected.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Inputs after named inputs are considered for affected...

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 722b2d0)
FrozenPandaz added a commit that referenced this pull request May 15, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

Inputs after named inputs are not considered for affected.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Inputs after named inputs are considered for affected...

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 722b2d0)
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants