Skip to content

fix(vite): Only attempt to amend test object if one exists - #26822

Merged
ndcunningham merged 1 commit into
nrwl:masterfrom
Jaspooky:patch-1
Jul 9, 2024
Merged

ndcunningham merged 1 commit into
nrwl:masterfrom
Jaspooky:patch-1

Conversation

@Jaspooky

@Jaspooky Jaspooky commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

Test object is assigned using optional chaining but previously did not check that any value had actually been assigned which would cause the getStart call to fail resulting in a failed migration.

Current Behavior

Migration fails if no matching test object is found.

Expected Behavior

Migration should not fail.

Related Issue(s)

I haven't opened an issue, just the PR. I can open an issue if required for tracking.

Test object is assigned using optional chaining but previously did not check that any value had actually been assigned which would cause the `getStart` call to fail resulting in a failed migration.
@Jaspooky
Jaspooky requested a review from a team as a code owner July 3, 2024 22:23
@Jaspooky
Jaspooky requested a review from ndcunningham July 3, 2024 22:23
@vercel

vercel Bot commented Jul 3, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev โฌœ๏ธ Ignored (Inspect) Visit Preview Jul 3, 2024 10:26pm

@ndcunningham
ndcunningham merged commit 8fd38cb into nrwl:master Jul 9, 2024
FrozenPandaz pushed a commit that referenced this pull request Jul 12, 2024
Test object is assigned using optional chaining but previously did not
check that any value had actually been assigned which would cause the
`getStart` call to fail resulting in a failed migration.

## Current Behavior
Migration fails if no matching test object is found.

## Expected Behavior
Migration should not fail.

## Related Issue(s)
I haven't opened an issue, just the PR. I can open an issue if required
for tracking.

(cherry picked from commit 8fd38cb)
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants