Repository navigation
fix(nsis): correct the chooseHowToInstall language key - #16333
Merged
Merged
Conversation
- Rename the misspelled NSIS key and keep a fallback for custom language files
FabianLars
approved these changes
Oct 19, 2026
This was referenced Oct 21, 2026
Luke-Lacina
added a commit
to TheVoxRox/mail
that referenced
this pull request
Nov 1, 2026
…string rename Tauri CLI 2.12.4 renames the misspelled NSIS language string choowHowToInstall to chooseHowToInstall in its bundled language files (tauri-apps/tauri#16333). Upstream's own template keeps a fallback to the old name; the template in frontend/src-tauri/windows is a copy that has no such fallback, so with the new CLI the English build would have had no text for the reinstall page's subheading. The template and Czech.nsh take the new name in the same commit as the bump, since 2.12.3 does not define it. regen:licenses after npm ci picks up svelte, vite and the rolldown/oxc packages vite pulls in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Luke-Lacina
added a commit
to TheVoxRox/mail
that referenced
this pull request
Nov 1, 2026
…th 5 updates (#813) * build(deps-dev): Bump the npm-development group across 1 directory with 5 updates Bumps the npm-development group with 5 updates in the /frontend directory: | Package | From | To | | --- | --- | --- | | [@tauri-apps/cli](https://github.com/tauri-apps/tauri) | `2.12.3` | `2.12.4` | | [knip](https://github.com/webpro-nl/knip/tree/HEAD/packages/knip) | `6.41.0` | `6.43.0` | | [svelte](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte) | `5.57.2` | `5.57.3` | | [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `8.71.2` | `8.72.1` | | [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `8.3.4` | `8.3.5` | Updates `@tauri-apps/cli` from 2.12.3 to 2.12.4 - [Release notes](https://github.com/tauri-apps/tauri/releases) - [Commits](https://github.com/tauri-apps/tauri/compare/@tauri-apps/cli-v2.12.3...@tauri-apps/cli-v2.12.4) Updates `knip` from 6.41.0 to 6.43.0 - [Release notes](https://github.com/webpro-nl/knip/releases) - [Commits](https://github.com/webpro-nl/knip/commits/knip@6.43.0/packages/knip) Updates `svelte` from 5.57.2 to 5.57.3 - [Release notes](https://github.com/sveltejs/svelte/releases) - [Changelog](https://github.com/sveltejs/svelte/blob/main/packages/svelte/CHANGELOG.md) - [Commits](https://github.com/sveltejs/svelte/commits/svelte@5.57.3/packages/svelte) Updates `typescript-eslint` from 8.71.2 to 8.72.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.72.1/packages/typescript-eslint) Updates `vite` from 8.3.4 to 8.3.5 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.5/packages/vite) --- updated-dependencies: - dependency-name: "@tauri-apps/cli" dependency-version: 2.12.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-development - dependency-name: knip dependency-version: 6.43.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-development - dependency-name: svelte dependency-version: 5.57.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-development - dependency-name: typescript-eslint dependency-version: 8.72.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-development - dependency-name: vite dependency-version: 8.3.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-development ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): record the npm-development bump and follow the NSIS string rename Tauri CLI 2.12.4 renames the misspelled NSIS language string choowHowToInstall to chooseHowToInstall in its bundled language files (tauri-apps/tauri#16333). Upstream's own template keeps a fallback to the old name; the template in frontend/src-tauri/windows is a copy that has no such fallback, so with the new CLI the English build would have had no text for the reinstall page's subheading. The template and Czech.nsh take the new name in the same commit as the bump, since 2.12.3 does not define it. regen:licenses after npm ci picks up svelte, vite and the rolldown/oxc packages vite pulls in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lukáš Lacina <33394048+Luke-Lacina@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.