Skip to content

Stardew Valley: Add money logic to traveling merchant - #5327

Merged
NewSoupVi merged 2 commits into
ArchipelagoMW:mainfrom
agilbert1412:StardewValley/add-money-logic-to-traveling-merchant
Sep 5, 2025
Merged

NewSoupVi merged 2 commits into
ArchipelagoMW:mainfrom
agilbert1412:StardewValley/add-money-logic-to-traveling-merchant

Conversation

@Jouramie

Copy link
Copy Markdown
Collaborator

What is this fixing or adding?

It seems that the travelling merchant did not have any money logic. It now requires being able to spend 1000 gold, which translate to having the shipping bin, or all the shops unlocked.

Before

image

After

image

How was this tested?

Yes

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions Bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Aug 13, 2025

@agilbert1412 agilbert1412 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical for tilesanity, and useful for others

@Ishigh1 Ishigh1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The price is in the right range, since the item price starts at 250
With 7.X this test will however need to be updated to also require inventory space, since the shipping bin cannot be used without

@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Aug 13, 2025
@agilbert1412

agilbert1412 commented Aug 13, 2025 •

Copy link
Copy Markdown
Collaborator

The price is in the right range, since the item price starts at 250 With 7.X this test will however need to be updated to also require inventory space, since the shipping bin cannot be used without

You always start with at least 4 slots, even in 7.x.x with the "no backpack" start. It's actually "less backpack start"

There are way too many places where we would need to write inventory logic and I was not willing to deal with that right then and there

@NewSoupVi
NewSoupVi merged commit 64d3c55 into ArchipelagoMW:main Sep 5, 2025
@Jouramie
Jouramie deleted the StardewValley/add-money-logic-to-traveling-merchant branch September 5, 2025 15:55
eternalcode0 pushed a commit to eternalcode0/Archipelago that referenced this pull request Dec 20, 2025
…5327)

* add rule to traveling merchant region

* add a test so kaito is happy
eternalcode0 pushed a commit to eternalcode0/Archipelago that referenced this pull request Dec 21, 2025
…5327)

* add rule to traveling merchant region

* add a test so kaito is happy
wcoldren pushed a commit to wcoldren/Archipelago that referenced this pull request Jun 18, 2026
…5327)

* add rule to traveling merchant region

* add a test so kaito is happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants