Repository navigation
Use default host name for flex health check - #5462
Merged
Merged
Conversation
Add a pre-check step that diffs against origin/main to determine if eng/build/Packages.props was modified. The worker version validation (which calls GitHub API) is now skipped for PRs that don't change host or worker versions, avoiding 429 rate limit errors on shared CI agents. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This reverts commit 29745ae.
Shyju Krishnankutty (kshyju)
approved these changes
Jul 8, 2026
Jacob Viau (jviau)
approved these changes
Jul 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Resolves #5465
Leverage defaultHostName instead of
.FirstOrDefault()ofenabledHostNamesproperty to make sure check goes to the correct site.Pull request checklist
release_notes.mdAdditional Information
Went back through the history w/ an agent, the use of
enabledHostNamesgoes all the way to "day one" and has no documented reasoning for why. One potential reason thatenabledHostNamesis used is because it only lists hostnames that are currently enabled/accessible, becausedefaultHostNameexists even if the site is stopped or hostname is disabled.That still seems incorrect to me. Using
defaultHostNameshould be more reliable because it returns the canonical*.azurewebsites.net hostname, avoiding issues with custom domains inenabledHostNamesthat might have different TLS/routing configurations.Example of what is returned from each:
{
"defaultHostName": "some-app-name.azurewebsites.net",
"enabledHostNames": [
"some-custom-domain-name.net",
"some-app-name.azurewebsites.net",
"some-app-name.scm.azurewebsites.net"
]
}
Testing