Skip to content

Require confirmation before forced bundle deletion - #5666

Merged
Shyju Krishnankutty (kshyju) merged 2 commits into
mainfrom
satvu-bundle-deletion-safeguard
Sep 29, 2026
Merged

Shyju Krishnankutty (kshyju) merged 2 commits into
mainfrom
satvu-bundle-deletion-safeguard

Conversation

@satvu

Copy link
Copy Markdown
Member

Summary

  • add a defense-in-depth confirmation before func bundles download --force recursively deletes an existing bundle directory
  • display the fully resolved deletion path and proceed only for an explicit y or yes; decline or EOF cancels before deletion and download
  • fail the command when confirmed cleanup cannot delete the directory
  • verify deletion with a sentinel file and verify declined cleanup preserves a configured external path

Validation

  • dotnet restore .\test\Cli\Func.UnitTests\Azure.Functions.Cli.UnitTests.csproj
  • dotnet test .\test\Cli\Func.UnitTests\Azure.Functions.Cli.UnitTests.csproj --filter "FullyQualifiedName~DownloadBundleActionTests" --no-restore (14 passed)
  • git diff --check

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@satvu
sarah (satvu) requested a review from a team as a code owner September 29, 2026 14:57
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@satvu

Copy link
Copy Markdown
Member Author

/azp run coretools.public

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@kshyju
Shyju Krishnankutty (kshyju) merged commit 87d4807 into main Sep 29, 2026
42 checks passed
@kshyju
Shyju Krishnankutty (kshyju) deleted the satvu-bundle-deletion-safeguard branch September 29, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants