Repository navigation
Fix npm networking issues - #5771
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The npm installer's expected archive names and formats do not match the staged release assets.
1 open issue
What changed in this PR
Restores npm packaging and publication for both CLI package names, replacing dependency restoration with offline tarball creation to support network-isolated builds.
Changes:
- Adds an offline packaging script that updates package identity while preserving locked dependencies.
- Re-enables npm artifacts, staging, and publication without changing manual release approval.
- Adds local regression tests for registry isolation, package contents, and failure handling.
| File | Description |
|---|---|
test/Installers/NpmPackaging.test.js |
Adds offline packaging and failure-path tests. |
eng/scripts/pack-npm.ps1 |
Creates both npm packages without registry access. |
eng/ci/templates/jobs/build.yml |
Invokes the offline packaging script. |
eng/ci/release/official-release.cli.yml |
Restores npm artifact staging and publication. |
Review effort: Balanced
Francisco Gamino (Francisco-Gamino)
approved these changes
Oct 27, 2026
Francisco Gamino (Francisco-Gamino)
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. I did not find any blocking issues with the implementation.
Non-blocking: the new NpmPackaging.test.js regression suite is not currently part of the automated CI path. It would be good to wire this suite into CI so the release-packaging regression remains covered.
The implementation itself looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Re-enables the npm packaging and publishing reverted in #5740 and #5742. The earlier attempt failed because npm ci fetched dependencies from the registry (EPERM on registry.npmjs.org/yauzl), which network isolation blocks.
Changes
Validation