Skip to content

Cherry-pick fix from #47112: Fix accidental-GA TypeSpec leaks from 2026-04-01 - #47169

Merged
Yangyang Lu (yangylu91) merged 2 commits into
search/dp-2026-10-01from
search/dp-2026-10-01-combine-04-ga-fix
Oct 12, 2026
Merged

Yangyang Lu (yangylu91) merged 2 commits into
search/dp-2026-10-01from
search/dp-2026-10-01-combine-04-ga-fix

Conversation

@yangylu91

@yangylu91 Yangyang Lu (yangylu91) commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #47112 (merged to main, and now merged into search/dp-2026-10-01 via parent PR #46315), removing the equivalent accidentally-GA'd preview-only elements from the unshipped 2026-10-01 API version.

What changed

The following elements had leaked into the unshipped 2026-10-01 GA surface and are removed here:

Element File
KnowledgeBaseAgenticReasoningActivityRecord.retrievalReasoningEffort models-knowledgebase.tsp
VectorFilterMode.strictPostFilter models-index.tsp
VectorQueryKind.imageUrl/imageBinary, VectorizableImageUrlQuery/VectorizableImageBinaryQuery models-index.tsp
AMLVectorizer/AMLParameters models-service.tsp

Not changed — intentionally legit GA in 2026-10-01

These two are not touched by this PR. They were only leaked in 2026-04-01 (already fixed by #47112) and are legitimately GA surface in 2026-10-01:

  • KnowledgeRetrievalReasoningEffort / KnowledgeRetrievalMinimalReasoningEffort — reachable via KnowledgeBaseRetrievalStartedEvent.reasoningEffort
  • maxCumulativeIndexerRuntimeSeconds — on SearchServiceLimits

Verified both remain present in the generated stable/2026-10-01/search.json.

Diff scope

Now that search/dp-2026-10-01 (base branch, parent PR #46315) has merged main and inherited #47112's 2026-04-01 fix, this PR's diff is reduced to exactly the 2026-10-01-specific removals above — no 2026-04-01 or unrelated spec changes.

Reference: https://msdata.visualstudio.com/Azure%20Search/_git/AzureSearch/pullrequest/2343313

Port of AzureSearch ADO PR 2343313: removes/version-gates several
preview-only API elements that had accidentally leaked into GA swagger
for the 2026-04-01 (shipped) and/or 2026-10-01 (unshipped) API versions.

- KnowledgeBaseAgenticReasoningActivityRecord.retrievalReasoningEffort:
  removed from both 2026-04-01 and 2026-10-01 (never legitimate on this record)
- KnowledgeRetrievalReasoningEffort / KnowledgeRetrievalMinimalReasoningEffort:
  gated out of 2026-04-01 only; remain legit GA in 2026-10-01
- maxCumulativeIndexerRuntimeSeconds: removed from 2026-04-01 only;
  remains legit GA in 2026-10-01
- VectorFilterMode.strictPostFilter: removed from both versions
- VectorizableImageUrlQuery / VectorizableImageBinaryQuery (and their
  VectorQueryKind enum members): removed from both versions, gated at
  model level
- AMLVectorizer / AMLParameters: removed from both versions, gated at
  model level

Cleaned up 2026-04-01 example JSON files referencing removed fields
and regenerated stable/2026-04-01 and stable/2026-10-01 search.json via
tsp compile.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@yangylu91 Yangyang Lu (yangylu91) changed the title Fix accidental-GA TypeSpec leaks from 2026-04-01 Merge changes from #47112: Fix accidental-GA TypeSpec leaks from 2026-04-01 Oct 10, 2026
@yangylu91 Yangyang Lu (yangylu91) changed the title Merge changes from #47112: Fix accidental-GA TypeSpec leaks from 2026-04-01 Cherry-pick fix from #47112: Fix accidental-GA TypeSpec leaks from 2026-04-01 Oct 10, 2026
@github-actions github-actions Bot added data-plane TypeSpec Authored with TypeSpec labels Oct 10, 2026
@yangylu91 Yangyang Lu (yangylu91) changed the title Cherry-pick fix from #47112: Fix accidental-GA TypeSpec leaks from 2026-04-01 Merge fix from #47112: Fix accidental-GA TypeSpec leaks from 2026-04-01 Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Python azure-search-documents
Java com.azure:azure-search-documents

Comment generated by After APIView workflow run.

@yangylu91 Yangyang Lu (yangylu91) changed the title Merge fix from #47112: Fix accidental-GA TypeSpec leaks from 2026-04-01 Cherry-pick fix from #47112: Fix accidental-GA TypeSpec leaks from 2026-04-01 Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Contributor readiness: required access

✅ No contributor-readiness issues found.

…h/dp-2026-10-01-combine-04-ga-fix

# Conflicts:
#	specification/search/data-plane/Search/models-index.tsp
#	specification/search/data-plane/Search/models-knowledgebase.tsp
#	specification/search/data-plane/Search/models-service.tsp
@yangylu91
Yangyang Lu (yangylu91) marked this pull request as ready for review October 12, 2026 18:13
@yangylu91
Yangyang Lu (yangylu91) merged commit 0bb090a into search/dp-2026-10-01 Oct 12, 2026
74 of 85 checks passed
@yangylu91
Yangyang Lu (yangylu91) deleted the search/dp-2026-10-01-combine-04-ga-fix branch October 12, 2026 18:13
Yangyang Lu (yangylu91) added a commit that referenced this pull request Oct 16, 2026
* Sync Search DP 2026-10-01 tsp changes from ADO

* Apply versions to namespace in client.tsp

* Apply versions to namespace client  in client.tsp

* Sync tsp from ADO to GH

* Reference 2026-10-01 Search swagger in readme

Co-authored-by: yangylu91 <53235012+yangylu91@users.noreply.github.com>

* Sync tsp from ADO to GH

* Sync tsp from ADO to GH

* Refresh changlog for 2026-10-01

* Remove duplicate @removed(Versions.v2026_10_01) lines

* Remove redundant @removed(Versions.v2026_10_01) on LegacyIndexes list params

The \list\ and \listWithSelectedProperties\ operations are already
fully removed at v2026_08_01_preview, so the same decorator on their
\\\/\\\/\\\ parameters is dead weight. Found by the
local Data-Plane API Reviewer agent; verified no-op via tsp compile
(no swagger diff).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Revert unrelated targetIndexName example tweak in 2026-08-01-preview

This SearchServiceCreateOrUpdateIndexer.json change is a cosmetic
example rename unrelated to the GA (2026-10-01) work; removing it
keeps this PR scoped to GA-only changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Reorder shared Operation alias params (TParams last) to stop perpetual false breaking-change flags on param position

* Search DP 2026-10-01 GA: Late spec changes (#46824)

* Add SearchField.organizationAccessExpiration for SharePoint Org-wide Link

* Promote runtime and indexersRuntime to GA as optional properties

* Update example files for runtime/indexersRuntime

* Update client.tsp with namespace for KS and list

* Add Page Size to listingPaginationQuery (#47041)

* [Late Fix] Promote GPT-5.4+ knowledge retrieval models to 2026-10-01 GA

* Fix accidental-GA TypeSpec leaks from 2026-04-01 (#47169)

Port of AzureSearch ADO PR 2343313: removes/version-gates several
preview-only API elements that had accidentally leaked into GA swagger
for the 2026-04-01 (shipped) and/or 2026-10-01 (unshipped) API versions.

- KnowledgeBaseAgenticReasoningActivityRecord.retrievalReasoningEffort:
  removed from both 2026-04-01 and 2026-10-01 (never legitimate on this record)
- KnowledgeRetrievalReasoningEffort / KnowledgeRetrievalMinimalReasoningEffort:
  gated out of 2026-04-01 only; remain legit GA in 2026-10-01
- maxCumulativeIndexerRuntimeSeconds: removed from 2026-04-01 only;
  remains legit GA in 2026-10-01
- VectorFilterMode.strictPostFilter: removed from both versions
- VectorizableImageUrlQuery / VectorizableImageBinaryQuery (and their
  VectorQueryKind enum members): removed from both versions, gated at
  model level
- AMLVectorizer / AMLParameters: removed from both versions, gated at
  model level

Cleaned up 2026-04-01 example JSON files referencing removed fields
and regenerated stable/2026-04-01 and stable/2026-10-01 search.json via
tsp compile.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update example file: KnowledgeBaseRetrieve.json

* [Search] SDK Updates (#47117)

* Add Page Size to listingPaginationQuery

* Expose pagination gen

* csharp pagination

* Fix C# Search pagination naming precedence and access scopes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Model Search retrieval SSE events with a common union base

Preserve existing SSE event payloads using data envelopes and enable union-extends.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Expose generated Search SSE event models for C#

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update namespaces

* cleanup

* fix CI

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Remove stale and preview-only examples

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: efrainretana <141282336+efrainretana@users.noreply.github.com>
Yangyang Lu (yangylu91) added a commit that referenced this pull request Nov 5, 2026
* Sync Search DP 2026-10-01 tsp changes from ADO

* Apply versions to namespace in client.tsp

* Apply versions to namespace client  in client.tsp

* Sync tsp from ADO to GH

* Reference 2026-10-01 Search swagger in readme

Co-authored-by: yangylu91 <53235012+yangylu91@users.noreply.github.com>

* Sync tsp from ADO to GH

* Sync tsp from ADO to GH

* Refresh changlog for 2026-10-01

* Remove duplicate @removed(Versions.v2026_10_01) lines

* Remove redundant @removed(Versions.v2026_10_01) on LegacyIndexes list params

The \list\ and \listWithSelectedProperties\ operations are already
fully removed at v2026_08_01_preview, so the same decorator on their
\\\/\\\/\\\ parameters is dead weight. Found by the
local Data-Plane API Reviewer agent; verified no-op via tsp compile
(no swagger diff).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Revert unrelated targetIndexName example tweak in 2026-08-01-preview

This SearchServiceCreateOrUpdateIndexer.json change is a cosmetic
example rename unrelated to the GA (2026-10-01) work; removing it
keeps this PR scoped to GA-only changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Reorder shared Operation alias params (TParams last) to stop perpetual false breaking-change flags on param position

* Search DP 2026-10-01 GA: Late spec changes (#46824)

* Add SearchField.organizationAccessExpiration for SharePoint Org-wide Link

* Promote runtime and indexersRuntime to GA as optional properties

* Update example files for runtime/indexersRuntime

* Update client.tsp with namespace for KS and list

* Add Page Size to listingPaginationQuery (#47041)

* [Late Fix] Promote GPT-5.4+ knowledge retrieval models to 2026-10-01 GA

* Fix accidental-GA TypeSpec leaks from 2026-04-01 (#47169)

Port of AzureSearch ADO PR 2343313: removes/version-gates several
preview-only API elements that had accidentally leaked into GA swagger
for the 2026-04-01 (shipped) and/or 2026-10-01 (unshipped) API versions.

- KnowledgeBaseAgenticReasoningActivityRecord.retrievalReasoningEffort:
  removed from both 2026-04-01 and 2026-10-01 (never legitimate on this record)
- KnowledgeRetrievalReasoningEffort / KnowledgeRetrievalMinimalReasoningEffort:
  gated out of 2026-04-01 only; remain legit GA in 2026-10-01
- maxCumulativeIndexerRuntimeSeconds: removed from 2026-04-01 only;
  remains legit GA in 2026-10-01
- VectorFilterMode.strictPostFilter: removed from both versions
- VectorizableImageUrlQuery / VectorizableImageBinaryQuery (and their
  VectorQueryKind enum members): removed from both versions, gated at
  model level
- AMLVectorizer / AMLParameters: removed from both versions, gated at
  model level

Cleaned up 2026-04-01 example JSON files referencing removed fields
and regenerated stable/2026-04-01 and stable/2026-10-01 search.json via
tsp compile.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update example file: KnowledgeBaseRetrieve.json

* Azure Search DP 2026-11-01-preview changes on top of 2026-10-01

* Fix tspconfig.yaml for tsp compiler 1.17.0

* Fix cspell error and examples

* Fix readme

* [Search] SDK Updates (#47117)

* Add Page Size to listingPaginationQuery

* Expose pagination gen

* csharp pagination

* Fix C# Search pagination naming precedence and access scopes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Model Search retrieval SSE events with a common union base

Preserve existing SSE event payloads using data envelopes and enable union-extends.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Expose generated Search SSE event models for C#

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update namespaces

* cleanup

* fix CI

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Sync Azure Search data-plane spec from AzureSearch (tsp-sync/2026-11-01-preview@935d68cc938)

* Remove stale and preview-only examples

* Remove stale examples

* Fix nit; update swagger

* remove stale example

* Remove example updates of old version to keep this PR clean

* Fix SpellCheck in description

* Fix Swagger lint by naming graph provenance document schema without changing wire format

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Mark knowledge source cache connection string as secret and write-only

Sync AzureSearch merge commit 38d19b5f (PR 2367055). Keep create/update request support, remove the connection string from response examples, and regenerate November preview OpenAPI and example copies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Mark query source authorization header as secret

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Keep GA multipart upload primary in generated Swagger

Reorder shared upload declarations without changing either operation contract; preserve preview binary upload as an x-ms-paths overload.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Refine GraphQueryDiagnostic properties with enum types; Set default kind of GraphGrounding; Update examples; Fix missing models in client.tsp

* Refine topic graph vector search and add filter-hint auto-configuration

- Add none, diverse, and balanced query variants, profile defaults, and candidate-pool settings.
- Share VectorSearchTopicGraphKind across index profiles and per-query options while preserving distinct model names.
- Add facet-based filter-hint auto-configuration with cache TTL and facet-count limits
- Update client.tsp, examples and swagger

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Remove duplicate namespace mappings in client.tsp

* Fix *VectorQueryTopicGraph models

* Refresh examples

* Only update description for minDiversityPoolSize and defaultMinDiversityPoolSize

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: efrainretana <141282336+efrainretana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data-plane Search TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant