Skip to content

[Feature Request] MicrosoftIdentityOptions and DefaultCertificateLoader should support user assigned managed identity #1007

Closed

Description

Is your feature request related to a problem? Please describe.
Currently, DefaultCertificateLoader only supports system assigned managed identities, whereas customers and partners also need it to support user assigned managed identity

Describe the solution you'd like
Have a new property named UserAssignedManagedIdentityClientId in MicrosoftIdentityOptions so that developers can provide the user assigned managed identity client ID.

public class MicrosoftIdentityOptions
{
 // Previous properties

 /// <summary>
 /// Used, when deployed to Azure, to specify explicitly a user assigned managed identity.
 /// See https://docs.microsoft.com/azure/active-directory/managed-identities-azure-resources/how-to-manage-ua-identity-portal.
 /// </summary>
 string? UserAssignedManagedIdentityClientId {get;set;}
}

For customers using ASP.NET (not core), and therefore directly the DefaultCertificateLoader, also expose it as a static public member of DefaultCertificateLoader

Additional context

Activity

  1. admsteck commented on Feb 23, 2021

    @admsteck

    The LoadFromKeyVault method of DefaultCertificateLoader needs both certificate and secret permissions in key vault. In our use case it would be beneficial if different client ids could be provided for the certificate client and secret client used within the LoadFromKeyVault method.

  2. jmprieur commented on Feb 24, 2021

    @jmprieur
    CollaboratorAuthor

    Adam Stechschulte (@admsteck) : do you want to provide a PR that we could examine?

  3. jmprieur commented on Feb 27, 2021

    @jmprieur
    CollaboratorAuthor

    PR is #1008

  4. jmprieur commented on Feb 27, 2021

    @jmprieur
    CollaboratorAuthor

    Wei replied this would be nice to have it to allow customers to pass user assigned MSI clientId from the code instead of changing App service settings,

  5. admsteck commented on Mar 1, 2021

    @admsteck

    The LoadFromKeyVault method of DefaultCertificateLoader needs both certificate and secret permissions in key vault. In our use case it would be beneficial if different client ids could be provided for the certificate client and secret client used within the LoadFromKeyVault method.

    I retract this comment. It appears our requirements have changed and the original scope of this issue/PR will be sufficient for our needs.

  6. jennyf19 commented on Mar 10, 2021

    @jennyf19
    Collaborator

    Included in 1.8.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions