You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Feature Request] MicrosoftIdentityOptions and DefaultCertificateLoader should support user assigned managed identity #1007
Is your feature request related to a problem? Please describe.
Currently, DefaultCertificateLoader only supports system assigned managed identities, whereas customers and partners also need it to support user assigned managed identity
Describe the solution you'd like
Have a new property named UserAssignedManagedIdentityClientId in MicrosoftIdentityOptions so that developers can provide the user assigned managed identity client ID.
publicclassMicrosoftIdentityOptions{// Previous properties/// <summary>/// Used, when deployed to Azure, to specify explicitly a user assigned managed identity./// See https://docs.microsoft.com/azure/active-directory/managed-identities-azure-resources/how-to-manage-ua-identity-portal./// </summary>string?UserAssignedManagedIdentityClientId{get;set;}}
For customers using ASP.NET (not core), and therefore directly the DefaultCertificateLoader, also expose it as a static public member of DefaultCertificateLoader
The LoadFromKeyVault method of DefaultCertificateLoader needs both certificate and secret permissions in key vault. In our use case it would be beneficial if different client ids could be provided for the certificate client and secret client used within the LoadFromKeyVault method.
Wei replied this would be nice to have it to allow customers to pass user assigned MSI clientId from the code instead of changing App service settings,
The LoadFromKeyVault method of DefaultCertificateLoader needs both certificate and secret permissions in key vault. In our use case it would be beneficial if different client ids could be provided for the certificate client and secret client used within the LoadFromKeyVault method.
I retract this comment. It appears our requirements have changed and the original scope of this issue/PR will be sufficient for our needs.
Activity
Adding support for user assigned managed identity
admsteck commentedon Feb 23, 2021
The LoadFromKeyVault method of DefaultCertificateLoader needs both certificate and secret permissions in key vault. In our use case it would be beneficial if different client ids could be provided for the certificate client and secret client used within the LoadFromKeyVault method.
jmprieur commentedon Feb 24, 2021
Adam Stechschulte (@admsteck) : do you want to provide a PR that we could examine?
jmprieur commentedon Feb 27, 2021
PR is #1008
jmprieur commentedon Feb 27, 2021
Wei replied this would be nice to have it to allow customers to pass user assigned MSI clientId from the code instead of changing App service settings,
admsteck commentedon Mar 1, 2021
I retract this comment. It appears our requirements have changed and the original scope of this issue/PR will be sufficient for our needs.
Adding support for user assigned managed identity (#1008)
jennyf19 commentedon Mar 10, 2021
Included in 1.8.0 release