Skip to content

[Feature Request] Leverage the new .WithCssRoutingHint in MSAL.NET 4.34.0 #1303

Closed

Description

Is your feature request related to a problem? Please describe.

  • Microsoft.Identity.Web:

  • MSAL.ENT 4.33.0 retro-fitted a similar API

    public sealed class AcquireTokenByAuthorizationCodeParameterBuilder : 
      AbstractConfidentialClientAcquireTokenParameterBuilder<AcquireTokenByAuthorizationCodeParameterBuilder> {
          public AcquireTokenByAuthorizationCodeParameterBuilder WithCcsRoutingHint(string userName);
          public AcquireTokenByAuthorizationCodeParameterBuilder WithCcsRoutingHint(string userObjectIdentifier, string tenantIdentifier);
      }
      public sealed class AcquireTokenOnBehalfOfParameterBuilder : 
      AbstractConfidentialClientAcquireTokenParameterBuilder<AcquireTokenOnBehalfOfParameterBuilder> {
          public AcquireTokenOnBehalfOfParameterBuilder WithCcsRoutingHint(string userName);
          public AcquireTokenOnBehalfOfParameterBuilder WithCcsRoutingHint(string userObjectIdentifier, string tenantIdentifier);
      }
      public sealed class GetAuthorizationRequestUrlParameterBuilder : 
      AbstractConfidentialClientAcquireTokenParameterBuilder<GetAuthorizationRequestUrlParameterBuilder> {
          public GetAuthorizationRequestUrlParameterBuilder WithCcsRoutingHint(string userObjectIdentifier, string tenantIdentifier);
      }

Describe the solution you'd like

  • Update the current code in Id.Web (still nice as it takes a ClaimsPrincipal), to use the new MSAL.NET 4.34.0 API

    public static AbstractAcquireTokenParameterBuilder<T> WithCcsRoutingHint<T>(
    this AbstractAcquireTokenParameterBuilder<T> builder,
    ClaimsPrincipal? user)
    where T : AbstractAcquireTokenParameterBuilder<T>
    {
    builder.WithExtraHttpHeaders(new Dictionary<string, string>
    {
    { Constants.XAnchorMailbox, CreateCcsRoutingHintFromHttpContext(user) },
    });
    return builder;
    }
    internal static string CreateCcsRoutingHintFromHttpContext(ClaimsPrincipal? user)
    {
    if (user != null)
    {
    string? oid = user.GetObjectId();
    string? tid = user.GetTenantId();
    if (!string.IsNullOrEmpty(oid) && !string.IsNullOrEmpty(tid))
    {
    return $"oid:{oid}@{tid}";
    }
    }
    return string.Empty;
    }

  • Use the new API instead of the .WithExtraHttpHeaders:

    .WithExtraHttpHeaders(new Dictionary<string, string> { { Constants.XAnchorMailbox, ccsRoutingHint } });

Describe alternatives you've considered
Leave the current code in Id.Web

Activity

  1. changed the title [-][Feature Request] Leverage the new .WithCssRoutingHint in MSAL.NET 4.33.0[/-] [+][Feature Request] Leverage the new .WithCssRoutingHint in MSAL.NET 4.34.0[/+] on Jul 8, 2021
  2. removed this from the 1.14.1 milestone on Jul 15, 2021
  3. jennyf19 commented on Jul 26, 2021

    @jennyf19
    Collaborator

    Included in 1.15 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions