You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Feature Request] In the L1/L2 cache, the L2 PUT and DELETE operations should be async fire and forget #1526
As per discussion with SharePoint cache owners, they have gotten a perf boost by executing L2 operations in 'fire and forget" mode. Particularly for Redis, PUT operations take a long time. The L1 cache will have been updated anyway.
We considered doing this before, but we discussed with henrikm (@henrik-me) and went with a re-try on failure. We'd have to see if they have set the re-try callback and then do fire and forget.
Activity
jmprieur commentedon Nov 11, 2021
How is this achieved, Bogdan Gavril (@bgavrilMS) ?
By removing the await and adding a pragma disable?
bgavrilMS commentedon Nov 12, 2021
No, you'd do
Have a look at this helper function that MSAL uses to perform refresh_in operation in the background: https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/master/src/client/Microsoft.Identity.Client/Internal/Requests/SilentRequestHelper.cs#L70
jennyf19 commentedon Nov 12, 2021
We considered doing this before, but we discussed with henrikm (@henrik-me) and went with a re-try on failure. We'd have to see if they have set the re-try callback and then do fire and forget.
bgavrilMS commentedon Nov 12, 2021
I was thinking about that as well. Maybe the re-try can be part of the fire and forget logic
jennyf19 commentedon Dec 23, 2021
closing as duplicate of #1047
jennyf19 commentedon Jan 8, 2022
Included in the [1.22.0 release](https://github.com/AzureAD/microsoft-identity-web/releases/tag/1.22.00