Skip to content

[Bug] DefaultCertificateLoader does not accept that name : LocalComputerΒ #1702

Closed

Description

Which version of Microsoft Identity Web are you using?
master

To repo:

  1. Create a CertificateDescription with CertificateStorePath = "LocalComputer/My".
  2. Try and load the cert.

The error has the following message:

IDW10703: Certificate store path must be of the form 'StoreLocation/StoreName'. StoreLocation must be one of 'CurrentUser', 'CurrentMachine'. StoreName must be empty or one of 'AddressBook', 'AuthRoot', 'CertificateAuthority', 'Disallowed', 'My', 'Root', 'TrustedPeople', 'TrustedPublisher'.

If you open up MMC the common names are: "CurrentUser" and "LocalComputer"
Since you already have support for "CurrentMachine", please add support for "LocalComputer".

See this document for names.

I is always a good idea to echo what was received.
The above error message could be written"
IDW10703: The Certificate store path received '.......' was not of the form....

Activity

  1. jennyf19 commented on Apr 11, 2022

    @jennyf19
    Collaborator

    BrentSchmaltz (@brentschmaltz) Not sure what the issue is. We are parsing the values out here, and using CurrentUser as the default.

    The only values for StoreLocation are CurrentUser and LocalMachine:
    image

  2. brentschmaltz commented on Apr 13, 2022

    @brentschmaltz
    ContributorAuthor

    jennyf19 there is no 'CurrentMachine'. Your error message, IDW10703, includes the name: 'CurrentMachine', it should be 'LocalMachine'.

  3. jennyf19 commented on Apr 13, 2022

    @jennyf19
    Collaborator

    BrentSchmaltz (@brentschmaltz) That's not what the issue says above, but thanks for clarifying. Will fix the error message.

  4. jennyf19 commented on Apr 14, 2022

    @jennyf19
    Collaborator

    fixed in #1704

  5. self-assigned this
    on Apr 14, 2022
  6. brentschmaltz commented on Apr 14, 2022

    @brentschmaltz
    ContributorAuthor

    jennyf19 thanks for fixing, when i wrote the bug i was confused because of the error message.
    Your explanation helped me understand what the issue was.
    Sorry for the confusion.

  7. jennyf19 commented on Apr 14, 2022

    @jennyf19
    Collaborator

    BrentSchmaltz (@brentschmaltz) it's fine! I was confused too so thanks for the explanation. I'll re-open until we release the updated message and then close.

  8. added this to the 1.24.0 milestone on Apr 20, 2022
  9. jennyf19 commented on Apr 20, 2022

    @jennyf19
    Collaborator

    Released in 1.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationfixed

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions