You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Input string was not in a correct format exception in method IsChromiumVersionAtLeast #1811
Incorrect Regexp in IsChromiumVersionAtLeast
"Chrom[^ /]+/(\d+)[.\d]* "
Corrected regexp
"Chrom[^ /]+/(\d+)[.\d]*"
It means Chrome can be only last in row
For some user agent string it is not true
For example "Mozilla/5.0 Windows NT 10.0 Win64 AppleWebKit/537.36 Chrome/69.0.3497.100"
Reproduction steps
in Startup.cs added next code
services.Configure(options =>
{
options.HandleSameSiteCookieCompatibility();
});
Try to open web application with userAgent: "Mozilla/5.0 Windows NT 10.0 Win64 AppleWebKit/537.36 Chrome/69.0.3497.100"
Error message
Input string was not in a correct format.
System.Number.ThrowOverflowOrFormatException(ParsingStatus status, TypeCode type)
at System.Convert.ToInt32(String value, IFormatProvider provider)
at Microsoft.Identity.Web.CookiePolicyOptionsExtensions.g__IsChromiumVersionAtLeast|3_7(Int32 major, <>c__DisplayClass3_0& )
at Microsoft.Identity.Web.CookiePolicyOptionsExtensions.g__DropsUnrecognizedSameSiteCookies|3_1(<>c__DisplayClass3_0& )
at Microsoft.Identity.Web.CookiePolicyOptionsExtensions.DisallowsSameSiteNone(String userAgent)
Id Web logs
No response
Relevant code snippets
publicstaticboolIsChromiumVersionAtLeastOriginal(stringuserAgent,intmajor){stringregex=@"Chrom[^ \/]+\/(\d+)[\.\d]* ";// Extract digits from first capturing group.Matchmatch=Regex.Match(userAgent,regex);intversion=Convert.ToInt32(match.Groups[1].Value,CultureInfo.CurrentCulture);returnversion>=major;}[TestCase("Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36")][TestCase("Mozilla/5.0 Windows NT 10.0 Win64 AppleWebKit/537.36 Chrome/69.0.3497.100")]publicvoidChromiumVersionIssueOriginalTest(stringuserAgent){Assert.DoesNotThrow(()=>CookiePolicyOptionsExtensions.IsChromiumVersionAtLeastOriginal(userAgent,51));}
Activity