Skip to content

Making ClientAssertion class public to inherit IDWeb repo on dMSI lib - #2079

Merged
jennyf19 merged 1 commit into
masterfrom
unknown repository
Feb 23, 2023
Merged

jennyf19 merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

Copy link
Copy Markdown

Making ClientAssertion class public to inherit IDWeb repo on dMSI lib

@jennyf19

Copy link
Copy Markdown
Collaborator

This class needs to remain internal because we may change its implementation, especially around the cache.. You can derive from ClientAssertionProviderBase.

@JoshLozensky

JLoze (JoshLozensky) commented Feb 17, 2023 •

Copy link
Copy Markdown
Contributor

ClientAssertionProviderBase has an abstract method on line 21 "GetClientAssertion" which requires returning a Task < ClientAssertion >. Without the ability to make a ClientAssertion object, or otherwise altering the coupling here, there is no way to implement the abstract method required to derive ClientAssertionProviderBase.

@jennyf19 jennyf19 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19
jennyf19 changed the base branch from rel/v2 to master February 23, 2023 04:48
@jennyf19
jennyf19 merged commit 93eaa53 into AzureAD:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants