Skip to content

Addition of environment variables as config source in TokenAcquirerFactory - #2483

Merged
Jean-Marc Prieur (jmprieur) merged 1 commit into
AzureAD:masterfrom
markjritchie:master
Sep 28, 2023
Merged

Jean-Marc Prieur (jmprieur) merged 1 commit into
AzureAD:masterfrom
markjritchie:master

Conversation

@markjritchie

Copy link
Copy Markdown
Contributor

Addition of environment variables as config source

  • [ X] You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • [ X] You've included inline docs for your change, where applicable.
  • [ X] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Addition of environment variables as a source for configuration values. Placed after appsettings.config so that they can be used to override variables. Especially useful in containers.

Fixes #2480

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for this addition, markjritchie

@jmprieur Jean-Marc Prieur (jmprieur) changed the title Addition of environment variables as config source Addition of environment variables as config source in TokenAcquirerFactory Sep 28, 2023
@jennyf19 jennyf19 added this to the 2.14.1 milestone Sep 28, 2023
@jmprieur
Jean-Marc Prieur (jmprieur) merged commit e528daa into AzureAD:master Sep 28, 2023
@simonschlegel

Copy link
Copy Markdown

When can we expect this to be released?

@jmprieur

Jean-Marc Prieur (jmprieur) commented Oct 4, 2023 •

Copy link
Copy Markdown
Collaborator

simonschlegel, markjritchie :we intend to release 2.15.0 tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for environment variables for configuration

4 participants