Skip to content

Jmprieur/test cert rotation - #2496

Merged
Jean-Marc Prieur (jmprieur) merged 7 commits into
masterfrom
jmprieur/testCertRotation
Oct 3, 2023
Merged

Jean-Marc Prieur (jmprieur) merged 7 commits into
masterfrom
jmprieur/testCertRotation

Conversation

@jmprieur

@jmprieur Jean-Marc Prieur (jmprieur) commented Oct 2, 2023 •

Copy link
Copy Markdown
Collaborator

Improving client certificate rotation

Description

  • Adding a ResetCertificates with an override for an enumeration of CredentialDescription
  • Adding a way for the apps to observe that the certs are selected or unselected: fixes [Feature Request] Provide an API to query the certificate that is currently in use for authentication Β #2458
  • Fix an issue in the rotation of client certificates.
  • Adds a test that create a daemon app registration (if not already there). Adds 2 certs (one that expires in 3mins, and one that is valid from in now+2 mins and expires in 10 mins, and add them to the app registration, We wait a few seconds (because the app registration is not immediate)

Then we acquire tokens for 5 mins. After 3 mins, IdWeb switches from the first certificate to the second.

image

@jennyf19 jennyf19 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

…redentialDescription

- Adding a way for the apps to observe that the certs are selected or unselected
- Fix an issue in the rotation of client certificates.
- Add an integration test.
Not running in AzureDevOps
Adding the certificate observability as experimental
Moved the CertificateRotationTests to TokenAcquirerTests (from Ms.Id.Web.Test.Integration) and use
Microsoft.Identity.Web.GraphServiceClient instead of Microsoft.Identity.Web.MicrosoftGraph (because
we need Graph 5 for the CertificateRotationTests)

@jennyf19 jennyf19 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great. thanks Jean-Marc Prieur (@jmprieur)
:shipit:

@jmprieur
Jean-Marc Prieur (jmprieur) merged commit 826ff82 into master Oct 3, 2023
@jmprieur
Jean-Marc Prieur (jmprieur) deleted the jmprieur/testCertRotation branch October 12, 2023 18:53
This was referenced Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Provide an API to query the certificate that is currently in use for authentication

2 participants